security: require cookie bearer auth on private/wallet RPC - #127
Open
ekulkisnek wants to merge 18 commits into
Open
security: require cookie bearer auth on private/wallet RPC#127ekulkisnek wants to merge 18 commits into
ekulkisnek wants to merge 18 commits into
Conversation
Unauthenticated private RPC exposes stop, seed import, transfers, and wallet control to anyone who can reach the port. Generate a mode-0600 cookie at <datadir>/.cookie and require Authorization: Bearer <token> on the private (or combined) RPC server. - Add rpc_auth cookie load/create helpers + unit tests - Wire ValidateRequestHeaderLayer on private/combined servers - CLI/integration tests/GUI pick up cookie or THUNDER_RPC_AUTH_TOKEN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unauthenticated private RPC exposes stop, seed import, transfers, and wallet control to anyone who can reach the port. This PR requires cookie bearer auth on the private (or combined) RPC server.
Changes
<datadir>/.cookieAuthorization: Bearer <token>on private/combined RPCrpc_authcookie load/create helpers + unit testsValidateRequestHeaderLayeron private/combined serversTHUNDER_RPC_AUTH_TOKENTest plan
THUNDER_RPC_AUTH_TOKENsucceed