forked from AustinCodingAcademy/javascript-workbook
-
Notifications
You must be signed in to change notification settings - Fork 0
Class3-piglatin #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LauraColten
wants to merge
4
commits into
gh-pages
Choose a base branch
from
class3-piglatin
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,88 +1,21 @@ | ||
| # This configuration was automatically generated from a CircleCI 1.0 config. | ||
| # It should include any build commands you had along with commands that CircleCI | ||
| # inferred from your project structure. We strongly recommend you read all the | ||
| # comments in this file to understand the structure of CircleCI 2.0, as the idiom | ||
| # for configuration has changed substantially in 2.0 to allow arbitrary jobs rather | ||
| # than the prescribed lifecycle of 1.0. In general, we recommend using this generated | ||
| # configuration as a reference rather than using it in production, though in most | ||
| # cases it should duplicate the execution of your original 1.0 config. | ||
| version: 2 | ||
| jobs: | ||
| build: | ||
| working_directory: ~/AustinCodingAcademy/javascript-workbook | ||
| parallelism: 1 | ||
| shell: /bin/bash --login | ||
| # CircleCI 2.0 does not support environment variables that refer to each other the same way as 1.0 did. | ||
| # If any of these refer to each other, rewrite them so that they don't or see https://circleci.com/docs/2.0/env-vars/#interpolating-environment-variables-to-set-other-environment-variables . | ||
| environment: | ||
| CIRCLE_ARTIFACTS: /tmp/circleci-artifacts | ||
| CIRCLE_TEST_REPORTS: /tmp/circleci-test-results | ||
| # In CircleCI 1.0 we used a pre-configured image with a large number of languages and other packages. | ||
| # In CircleCI 2.0 you can now specify your own image, or use one of our pre-configured images. | ||
| # The following configuration line tells CircleCI to use the specified docker image as the runtime environment for you job. | ||
| # We have selected a pre-built image that mirrors the build environment we use on | ||
| # the 1.0 platform, but we recommend you choose an image more tailored to the needs | ||
| # of each job. For more information on choosing an image (or alternatively using a | ||
| # VM instead of a container) see https://circleci.com/docs/2.0/executor-types/ | ||
| # To see the list of pre-built images that CircleCI provides for most common languages see | ||
| # https://circleci.com/docs/2.0/circleci-images/ | ||
| docker: | ||
| - image: circleci/build-image:ubuntu-14.04-XXL-upstart-1189-5614f37 | ||
| command: /sbin/init | ||
| - image: circleci/node:8.9.4 | ||
| working_directory: ~/repo | ||
|
|
||
| steps: | ||
| # Machine Setup | ||
| # If you break your build into multiple jobs with workflows, you will probably want to do the parts of this that are relevant in each | ||
| # The following `checkout` command checks out your code to your working directory. In 1.0 we did this implicitly. In 2.0 you can choose where in the course of a job your code should be checked out. | ||
| - checkout | ||
| # Prepare for artifact and test results collection equivalent to how it was done on 1.0. | ||
| # In many cases you can simplify this from what is generated here. | ||
| # 'See docs on artifact collection here https://circleci.com/docs/2.0/artifacts/' | ||
| - run: mkdir -p $CIRCLE_ARTIFACTS $CIRCLE_TEST_REPORTS | ||
| # This is based on your 1.0 configuration file or project settings | ||
| - run: | ||
| working_directory: ~/AustinCodingAcademy/javascript-workbook | ||
| command: nvm install 7.7.4 && nvm alias default 7.7.4 | ||
| # Dependencies | ||
| # This would typically go in either a build or a build-and-test job when using workflows | ||
| # Restore the dependency cache | ||
| - restore_cache: | ||
| keys: | ||
| # This branch if available | ||
| - v1-dep-{{ .Branch }}- | ||
| # Default branch if not | ||
| - v1-dep-gh-pages- | ||
| # Any branch if there are none on the default branch - this should be unnecessary if you have your default branch configured correctly | ||
| - v1-dep- | ||
| # The following line was run implicitly in your 1.0 builds based on what CircleCI inferred about the structure of your project. In 2.0 you need to be explicit about which commands should be run. In some cases you can discard inferred commands if they are not relevant to your project. | ||
| - run: if [ -z "${NODE_ENV:-}" ]; then export NODE_ENV=test; fi | ||
| - run: export PATH="~/AustinCodingAcademy/javascript-workbook/node_modules/.bin:$PATH" | ||
| - run: npm install | ||
| # Save dependency cache | ||
| - save_cache: | ||
| key: v1-dep-{{ .Branch }}-{{ epoch }} | ||
| paths: | ||
| # This is a broad list of cache paths to include many possible development environments | ||
| # You can probably delete some of these entries | ||
| - vendor/bundle | ||
| - ~/virtualenvs | ||
| - ~/.m2 | ||
| - ~/.ivy2 | ||
| - ~/.bundle | ||
| - ~/.go_workspace | ||
| - ~/.gradle | ||
| - ~/.cache/bower | ||
| - ./node_modules | ||
| # Test | ||
| # This would typically be a build job when using workflows, possibly combined with build | ||
| # This is based on your 1.0 configuration file or project settings | ||
| - run: npm run lint | ||
| # Teardown | ||
| # If you break your build into multiple jobs with workflows, you will probably want to do the parts of this that are relevant in each | ||
| # Save test results | ||
| - store_test_results: | ||
| path: /tmp/circleci-test-results | ||
| # Save artifacts | ||
| - store_artifacts: | ||
| path: /tmp/circleci-artifacts | ||
| - store_artifacts: | ||
| path: /tmp/circleci-test-results | ||
| - checkout | ||
|
|
||
| - restore_cache: | ||
| keys: | ||
| - npm-packages-v1-{{ .Branch }}-{{ checksum "package-lock.json" }} | ||
| - npm-packages-v1-{{ .Branch }}- | ||
| - npm-packages-v1- | ||
| - run: npm install | ||
| - save_cache: | ||
| paths: | ||
| - node_modules | ||
| key: npm-packages-v1-{{ .Branch }}-{{ checksum "package-lock.json" }} | ||
| - run: 'npm run lint' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to try and avoid mutating data, so store the formatted word into a new const and use that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! Made the correction. Thanks!