feat(sonos): add experimental local playback targets - #391
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
|
@mrzhbr Do you have any logging to enable debugging? I have a firewalled network, and tested this out with logging on my router - i'm not seeing the SSDP discovery packet from Spotatui. I can use the Sonos S2 app and it is receiving SSDP messages on the same laptop, at the same time that spotatui isn't finding the players, however is uses both When looking at tcpdump while hitting I get some responses like this after a few seconds: Which seems to match your code for device filtering: However nothing is showing up in the devices pane. |
Summary
sonos:<UUID>and route local transport, seek, volume, metadata, CLI, and playbar behavior through a dedicated Sonos backendHardware validation
Validated on standalone S1 and S2 rooms, including multiple-room selection:
Grouped-room coordinator behavior is covered by mock integration tests but could not be hardware-tested. Sonos queue viewing and Sonos shuffle/repeat remain intentionally unsupported.
Verification
cargo fmt --all --checkcargo clippy --no-default-features --features telemetry -- -D warningscargo test --no-default-features --features telemetry— 519 passedcargo clippy -- -D warningscargo test— 738 passedcargo clippy --features all-sources -- -D warningsRelated to #251.