Skip to content

[lua] Replace Magic Numbers in Tavnazia, Nashmau, Shadowreign shops#9705

Merged
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
Hatberg:magic-numbers-nashmau-shadowreign
Apr 4, 2026
Merged

[lua] Replace Magic Numbers in Tavnazia, Nashmau, Shadowreign shops#9705
Xaver-DaRed merged 1 commit intoLandSandBoat:basefrom
Hatberg:magic-numbers-nashmau-shadowreign

Conversation

@Hatberg
Copy link
Copy Markdown
Contributor

@Hatberg Hatberg commented Apr 3, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Replaces the Magic Numbers in Tavnazia, Nashmau and Shadowreign shops with xi.item.ITEMNAME entries
  • Updates item.lua with missing items

Steps to test these changes

!zone Bastok_Markets_[S]
!gotoname Blingbrix
Compare shop items

!gotoname Silke
Compare shop items

!zone Bibiki_Bay
!gotoname Pohka_Chichiyowahl

!zone Fort_Karugo-Narugo_[S]
!gotoname Spondulix
Compare shop items (NOTE: could not test)

!zone Mog_Garden
!gotoname Green_Thumb_Moogle

!zone Nashmau
!gotoname Chichiroon
Compare shop items

!gotoname Jajaroon
Compare shop items

!gotoname Mamaroon
Compare shop items

!gotoname Pipiroon
Compare shop items

!gotoname Poporoon
Compare shop items

!gotoname Wata_Khamazom
Compare shop items

!gotoname Yoyoroon
Compare shop items

!zone Southern_San_dOria_[S]
!gotoname Geltpix
Compare shop items

!zone Tavnazian_Safehold
!gotoname Caiphimonride
Compare shop items

!gotoname Komalata
Compare shop items

!gotoname Mazuro-Oozuro
Compare shop items

!gotoname Melleupaux
Compare shop items

!gotoname Migran
Compare shop items

!gotoname Misseulieu
Compare shop items

!gotoname Nilerouche
Compare shop items

!zone The_Eldieme_Necropolis_[S]
!gotoname Layton
Compare shop items

!zone Windurst_Waters_[S]
!gotoname Ezura-Romazura
Compare shop items

!gotoname Pelftrix
Compare shop items

@Xaver-DaRed Xaver-DaRed force-pushed the magic-numbers-nashmau-shadowreign branch 2 times, most recently from 0944d9a to b31c6c9 Compare April 3, 2026 11:25
@Xaver-DaRed Xaver-DaRed force-pushed the magic-numbers-nashmau-shadowreign branch from b31c6c9 to 2a5c95b Compare April 4, 2026 11:10
@Xaver-DaRed Xaver-DaRed merged commit 0548a7d into LandSandBoat:base Apr 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants