This repository was archived by the owner on Oct 12, 2025. It is now read-only.
[OneBot] Fix private chat replies do not have an id#857
Merged
Conversation
DarkRRb
requested review from
a user,
Decrabbityyy,
Executor-Cheng,
KusaGumina,
Linwenxuan04,
Copilot,
pk5ls20 and
sisi0318
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where private chat replies did not have an ID by introducing separate lookup logic for group and private chats and simplifying the return path.
- Adds conditional logic to compute or lookup the message hash based on whether the chain is a group chat.
- Unifies the reply segment creation by defaulting missing IDs to
"0".
Comments suppressed due to low confidence (2)
Lagrange.OneBot/Message/Entity/ReplySegment.cs:44
- [nitpick] Rename local variable
idtomessageIdorreplyIdto improve clarity about what this value represents.
int? id;
Lagrange.OneBot/Message/Entity/ReplySegment.cs:45
- Add unit tests for the private chat branch (
chain.IsGroup == false) to verify the new database lookup correctly retrieves or defaults the reply ID.
if (chain.IsGroup)
| .FirstOrDefault(record => record.Id == MessageRecord.CalcMessageHash(forward.MessageId, forward.Sequence))? | ||
| .Id); | ||
| int? id; | ||
| if (chain.IsGroup) |
There was a problem hiding this comment.
[nitpick] Consider extracting the group vs. private chat ID resolution logic into a dedicated helper method to reduce complexity in FromEntity.
sisi0318
approved these changes
Jun 3, 2025
This was
linked to
issues
Jun 3, 2025
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.