Merged
Conversation
… logic - Added ActionApplication for managing actions with methods to create, list, get, update, delete actions, and execute them based on triggers. - Introduced DTOs for action inputs and outputs. - Implemented action execution logic with step handling. - Created DocumentApp for document management with necessary dependencies. - Refactored favorite management into a separate FavoriteApp. - Updated user application to utilize FavoriteApp for managing user favorites. - Introduced ports for various application functionalities including action, document, favorite, and user management. - Removed deprecated user favorite methods and integrated with the new FavoriteApp. - Updated HTTP handlers and routes to accommodate new application structure.
- Changed `SpaceApp` to `SpaceApplication` and updated all related method signatures in the space package. - Changed `UserApp` to `UserApplication` and updated all related method signatures in the user package. - Introduced a new `WebhookApplication` struct and refactored all webhook-related methods accordingly. - Updated dependency injection in the infrastructure layer to reflect the new struct names. - Removed the old `webhook.go` file and split its functionality into multiple files for better organization.
- Updated PermissionApplication to use application ports for Space, Drawing, Document, and Database operations. - Refactored UpsertDatabasePermission, UpsertDocumentUserPermission, and UpsertDrawingUserPermission methods to utilize new application ports. - Introduced UpsertSpaceGroupPermission and updated UpsertSpaceUserPermission to leverage application ports. - Added new DTOs for space permissions and document checks. - Enhanced SpaceApplication to include PermissionApp and refactored space creation and deletion logic. - Updated dependency injection in infrastructure and HTTP routers to accommodate new permission handling. - Adjusted handlers in HTTP controllers for database, document, drawing, and space to utilize the new permission application methods.
- Updated references from `App` to `Application` for consistency across various controllers including Document, Drawing, Space, User, and Webhook. - Adjusted method calls in handlers to align with the new naming convention. - Ensured all instances of application references are updated to maintain code clarity and uniformity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the action application layer to improve maintainability and modularity by splitting a large monolithic file (
action.go) into multiple focused files, each handling a specific aspect of the action workflow. It also reorganizes DTOs into separate files for clarity and updates the CI/CD workflows to download the UI from a release instead of building it locally. Additionally, minor configuration and workflow improvements are included.Action Application Refactor
application/action/action.gofile is removed and replaced by multiple single-responsibility files (such asaction_application.go,create_action.go,delete_action.go, etc.), each implementing a specific method of the action application logic. This enhances code organization and maintainability. [1] [2] [3] [4]create_action.go,delete_action.go,get_action.go, etc.), making the codebase easier to navigate and understand. [1] [2] [3] [4] [5] [6] [7] [8]CI/CD Workflow Improvements
pr.yaml,release.yaml,nightly.yaml) are updated to download the latest UI release artifact from thenexo-uirepository instead of building the UI locally, streamlining the build process and reducing build time. [1] [2] [3]Configuration Update
.air.tomlconfiguration is updated to exclude theuidirectory from live reloads, preventing unnecessary rebuilds during development.