Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how OpenAPIOptions.RequiredRoles is enforced during authorization and updates the associated tests to match the new behavior.
Changes:
- Change
checkRequiredRolesfrom “must have all roles” (AND) to “must have at least one role” (OR). - Update
TestRequiredRolesmulti-role route and subtests to reflect OR semantics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| auth.go | Updates required-role authorization logic to OR semantics and changes the 403 error message. |
| auth_test.go | Updates route/test expectations for multi-role access using OR semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
auth.go
Outdated
Comment on lines
219
to
221
| // checkRequiredRoles checks that the authenticated user has at least one of the required roles (OR semantics). | ||
| // Called inside validateAuthorization after auth context is established, before resource access checks. | ||
| func checkRequiredRoles(authCtx *AuthContext, authService AuthorizationService, requiredRoles []string) error { |
auth.go
Outdated
| } | ||
| } | ||
| return nil | ||
| return &AuthError{StatusCode: 403, Message: fmt.Sprintf("none of the required roles found: %v", requiredRoles)} |
| @@ -681,8 +681,8 @@ func TestRequiredRoles(t *testing.T) { | |||
| } | |||
| }) | |||
|
|
|||
…s in route security
…RequiredRoles function
…amples for improved clarity and completeness. Add detailed configuration options and examples for authentication and authorization. Revise HTTP methods section to include PATCH and HEAD. Improve documentation on validation, error handling, and role-based access control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.