Fix AuthErrorHandler behavior and improve validation logic#44
Merged
moutonjeremy merged 5 commits intomainfrom Mar 13, 2026
Merged
Fix AuthErrorHandler behavior and improve validation logic#44moutonjeremy merged 5 commits intomainfrom
moutonjeremy merged 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts config merging in New() so that configuring only AuthErrorHandler (or only handler functions) doesn’t inadvertently disable default request validation and OpenAPI docs, and updates related comments/tests.
Changes:
- Update
New()config-merging “restore defaults” logic to treatAuthErrorHandlersimilar toValidationErrorHandler. - Clarify
AuthErrorHandlerfield comment to note it may handle 5xxAuthErrorresponses. - Add a regression test ensuring
AuthErrorHandler-only config preserves default validation and docs routes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
types.go |
Updates AuthErrorHandler comment to include 5xx cases. |
fiberoapi.go |
Adjusts default-restoration heuristic when only handlers are configured. |
custom_validation_error_test.go |
Adds test ensuring AuthErrorHandler alone doesn’t disable defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the AuthErrorHandler does not disable validation or OpenAPI documentation when set alone. Update the logic for restoring defaults in the New function to account for cases where only error handlers are configured. Additionally, clarify the AuthErrorHandler comment to include 5xx errors in its configuration.