Skip to content

Add test coverage for CycleCheckAction and CheckEdgesAction #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-jeckels merged 2 commits into from
May 27, 2026
+19 −2
Merged

Add test coverage for CycleCheckAction and CheckEdgesAction #3021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dfdbb5
Add test coverage for CycleCheckAction and CheckEdgesAction
labkey-jeckels May 27, 2026
8d3faf0
Cleanup
labkey-jeckels May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/org/labkey/test/tests/SampleTypeLineageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.labkey.remoteapi.CommandException;
import org.labkey.remoteapi.SimpleGetCommand;
import org.labkey.remoteapi.experiment.LineageCommand;
import org.labkey.remoteapi.experiment.LineageNode;
import org.labkey.remoteapi.experiment.LineageResponse;
Expand All @@ -14,6 +15,7 @@
import org.labkey.test.Locator;
import org.labkey.test.TestFileUtils;
import org.labkey.test.TestTimeoutException;
import org.labkey.test.WebTestHelper;
import org.labkey.test.categories.Daily;
import org.labkey.test.components.ext4.Window;
import org.labkey.test.params.FieldDefinition;
Expand Down Expand Up @@ -55,7 +57,7 @@ public class SampleTypeLineageTest extends BaseWebDriverTest
@Override
public List<String> getAssociatedModules()
{
return Arrays.asList("experiment");
return List.of("experiment");
}

@Override
Expand Down Expand Up @@ -842,7 +844,7 @@ public void testDeleteLineageParent() throws IOException, CommandException
// create a sample type with the following explicit domain columns
SampleTypeDefinition sampleType = new SampleTypeDefinition("Family");
TestDataGenerator sampleGenerator = sampleType.create(createDefaultConnection(), getProjectName());

sampleGenerator.addRow(List.of("A"));
sampleGenerator.addRow(List.of("B"));
sampleGenerator.addCustomRow(Map.of("name", "C", "MaterialInputs/Family", "A,B"));
Expand Down Expand Up @@ -1216,4 +1218,19 @@ public void testDeleteSamplesSomeWithDerivedSamples()

}

@Test
public void testDiagnosticActions() throws IOException, CommandException
{
// CycleCheckAction: confirm the page loads and the acyclic test data reports no cycles
beginAt(WebTestHelper.buildURL("experiment", PROJECT_NAME, "cycleCheck"));
assertTextPresent("This operation can use a lot of memory.");
clickButton("Continue");
assertTextPresent("No cycles found");

// CheckEdgesAction: confirm the API returns success with an empty cycle list
var cmd = new SimpleGetCommand("experiment", "checkEdges");
Map<String, Object> response = cmd.execute(createDefaultConnection(), "/" + PROJECT_NAME).getParsedData();
assertEquals("CheckEdgesAction should report success", Boolean.TRUE, response.get("success"));
assertEquals("CheckEdgesAction should find no cycle edges", List.of(), response.get("result"));
}
}