Skip to content

Add link to "Register" for a new account #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vagisha merged 2 commits into from
Jan 30, 2026
Merged

Add link to "Register" for a new account #1173

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36d8eaa
We will enable self-sign-up on PanoramaWeb. Add a link to "Register" …
vagisha Jan 29, 2026
e753199
- Use LoginUrl getRegisterUrl()
vagisha Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/org/labkey/targetedms/TargetedMSController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4461,13 +4461,20 @@ public String getDataRegionNameSmallMolecule()
@NotNull
private static HtmlView getLoginView(ViewContext context, Container container)
{
ActionURL registerUrl = new ActionURL("login", "register", container);
Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a PR to expose this via LoginUrls. Please switch to use that.

LabKey/platform#7372

registerUrl.addReturnUrl(context.getActionURL());

return new HtmlView(DOM.createHtmlFragment(
DOM.DIV(cl("alert alert-info"),
"Please ",
DOM.A(at(style, "font-weight: bold;",
href, PageFlowUtil.urlProvider(LoginUrls.class).getLoginURL(container, context.getActionURL())),
"login"),
" to view this data")));
"Login"),
" to view this data.",
DOM.BR(),
Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest conditionalizing this with a check to AuthenticationManager.isRegistrationEnabled(). Otherwise, on other servers it would send the user to a 404.

"Don't have an account? ",
DOM.A(at(style, "font-weight: bold;",
href, registerUrl),
"Register"))));
}

@RequiresPermission(ReadPermission.class)
Expand Down