Skip to content

Handle creating a duplicate custom new metric #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankurjuneja merged 5 commits into from
Dec 30, 2025
Merged

Handle creating a duplicate custom new metric #1154

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8129ee4
Handle creating a duplicate custom new metric
ankurjuneja Dec 24, 2025
d942f4e
code review suggestions and automation testing support for duplicate …
ankurjuneja Dec 28, 2025
e76a799
code review suggestion - rename variable
ankurjuneja Dec 29, 2025
595fae1
add wait for plots in qc annotation test
ankurjuneja Dec 30, 2025
7c7dbfc
fix add new metric regression
ankurjuneja Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 70 additions & 24 deletions resources/web/PanoramaPremium/window/AddNewMetricWindow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,36 +285,82 @@ Ext4.define('Panorama.Window.AddCustomMetricWindow', {
this.queryError.setVisible(!isValid);
},

saveNewMetric: function () {
var isValid = this.validateValues();
checkMetricNameExists: function (metricName, callback) {
let filterArray = [LABKEY.Filter.create('Name', metricName, LABKEY.Filter.Types.EQUAL)];

if(isValid) {
var records = [];
var newMetric = {};
newMetric.Name = this.metricNameField.getValue();
newMetric.QueryName = this.queriesCombo.getValue();
newMetric.YAxisLabel = this.yAxisLabelField.getValue();
newMetric.PrecursorScoped = this.metricTypeCombo.getValue();
// If updating, exclude the current metric from the check
if (this.operation === this.update && this.metric) {
filterArray.push(LABKEY.Filter.create('id', this.metric.id, LABKEY.Filter.Types.NOT_EQUAL));
}

if(this.operation === this.update) {
newMetric.id = this.metric.id;
LABKEY.Query.selectRows({
containerPath: LABKEY.container.id,
schemaName: this.SCHEMA_NAME,
queryName: 'qcmetricconfiguration',
filterArray: filterArray,
scope: this,
success: function (data) {
callback.call(this, data.rows.length > 0);
},
failure: function () {
callback.call(this, false);
}
});
},

records.push(newMetric);
saveNewMetric: function () {
let isValid = this.validateValues();

LABKEY.Query.saveRows({
containerPath: LABKEY.container.id,
commands: [{
schemaName: 'targetedms',
queryName: 'qcmetricconfiguration',
command: this.operation,
rows: records
}],
scope: this,
method: 'POST',
success: function () {
window.location.reload();
if(isValid) {
let metricName = this.metricNameField.getValue();

// Check if metric name already exists
this.checkMetricNameExists(metricName, function (exists) {
if (exists) {
let errorMessage = 'A metric with the name "' + Ext4.util.Format.htmlEncode(metricName) + '" already exists. Please choose a different name.';
Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're using setText(), this ends up double-encoding.,

this.queryError.setText(errorMessage);
this.queryError.setVisible(true);
this.metricNameField.setActiveError('Metric name already exists');
return;
}

let records = [];
let newMetric = {};
newMetric.Name = metricName;
newMetric.QueryName = this.queriesCombo.getValue();
newMetric.YAxisLabel = this.yAxisLabelField.getValue();
newMetric.PrecursorScoped = this.metricTypeCombo.getValue();

if (this.operation === this.update) {
newMetric.id = this.metric.id;
}

records.push(newMetric);

LABKEY.Query.saveRows({
containerPath: LABKEY.container.id,
commands: [{
schemaName: 'targetedms',
queryName: 'qcmetricconfiguration',
command: this.operation,
rows: records
}],
scope: this,
method: 'POST',
success: function () {
window.location.reload();
},
failure: function (response) {
let errorMessage = 'Error saving metric';
if (response && response.exception) {
errorMessage = response.exception;
} else if (response && response.message) {
errorMessage = response.message;
}
this.queryError.setText(errorMessage);
this.queryError.setVisible(true);
}
});
});
}

Expand Down