Skip to content

Improve line numbers in code review comments #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-jeckels wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −0
Open

Improve line numbers in code review comments #1333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .claude/commands/review-pr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ Steps:
2. Run `gh pr diff $ARGUMENTS` to get the full diff.
3. For each file changed, if you need more context than the diff provides, read the relevant file(s).

**IMPORTANT — Line Numbers**: Do NOT use line numbers from the diff output file (e.g., from a saved tool result). Those are offsets within the diff text, not actual source line numbers. To cite an accurate line number in a finding, read the actual source file and find the line there. If you cannot confirm a line number, omit it and reference the code by method or function name instead.

Then perform a thorough review in this exact order:

---
Expand Down
Loading