Avoid pulling too many objects into memory for indexing#7689
Open
labkey-jeckels wants to merge 6 commits into
Open
Avoid pulling too many objects into memory for indexing#7689labkey-jeckels wants to merge 6 commits into
labkey-jeckels wants to merge 6 commits into
Conversation
| if (modifiedSince != null) | ||
| filterSQL.append(" AND ER.Modified > ?").add(modifiedSince); | ||
|
|
||
| List<? extends ExpRun> runs = ExperimentService.get().getExpRuns(filterSQL, _ -> true, queue.getContainer(), SearchService.INDEXING_LIMIT); |
Contributor
There was a problem hiding this comment.
I see that this uses ORDER BY RowId, but this contract isn't very explicit. I think maxRowIdProcessed is implicit final, I like the readability of making it explicit.
| materials.forEach(m -> { | ||
| ExpMaterialImpl impl = new ExpMaterialImpl(m); | ||
| impl.index(queue, null /* null tableInfo since samples may belong to multiple containers*/); | ||
| maxRowIdProcessed.setValue(Math.max(maxRowIdProcessed.longValue(), impl.getRowId())); |
Contributor
There was a problem hiding this comment.
(applies to above as well). How would we detect that our assumption of ordering holds? Should we throw an exception if impl.getRowId() is ever < maxRowIdProcessed?
labkey-matthewb
approved these changes
May 26, 2026
labkey-matthewb
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
I investigated a heap dump yesterday that had 1.6 million newly created materials/samples in memory in an attempt to index them. We should work in much smaller batches.
Changes
Tasks 📍
Manual TestingTest Automation