Issue 1135: Update locators for Sign In that changed from link to button

assay/package.json

@@ -55,7 +55,7 @@
     }
   },
   "dependencies": {
-    "@labkey/components": "7.38.0"
+    "@labkey/components": "7.39.0"
   },
   "devDependencies": {
     "@labkey/build": "9.1.3",

core/package.json

@@ -57,7 +57,7 @@
     }
   },
   "dependencies": {
-    "@labkey/components": "7.38.0",
+    "@labkey/components": "7.39.0",
     "@labkey/themes": "1.9.3"
   },
   "devDependencies": {

core/resources/views/login.html

@@ -3,26 +3,27 @@
     <div class="labkey-error" id="errors"></div>
     <div class="auth-form-body">
         <label for="email">Email</label>
-        <input id="email" name="email" type="text" class="input-block" tabindex="1" autocomplete="off">
+        <input id="email" name="email" type="text" class="input-block" autocomplete="off">
         <label for="password">Password</label>
         <div class="forgot-password-link">
             <a href="login-resetPassword.view">Forgot password</a>
         </div>
-        <input id="password" name="password" type="password" class="input-block" tabindex="2" autocomplete="off">
-        <input tabindex="3" type="checkbox" name="remember" id="remember" checked> Remember my email address
+        <input id="password" name="password" type="password" class="input-block" autocomplete="off">
+        <input aria-labelledby="remember-label" type="checkbox" name="remember" id="remember" checked >
+        <span id="remember-label">Remember my email address</span>
         <div class="termsOfUseSection" hidden>
             <div class="auth-header auth-item">Terms of Use</div>
             <div class="toucontent auth-item termsOfUseContent"></div>
             <div class="auth-item">
-                <input type="checkbox" tabindex="4" name="approvedTermsOfUse" id="approvedTermsOfUse" class="auth-item">
+                <input type="checkbox" name="approvedTermsOfUse" id="approvedTermsOfUse" class="auth-item">
                 <label for="approvedTermsOfUse">I agree to these terms</label>
             </div>
         </div>
         <input type="hidden" name="termsOfUseType" id="termsOfUseType">
         <div class="auth-item auth-credentials-submit">
             <!-- Note: login.js attaches an authenticateUser() click event to elements with classes "loginSubmitButton" and "signin-btn" -->
             <input type="submit" tabindex="-1" class="loginSubmitButton"/>
-            <a tabindex="5" class="labkey-button primary signin-btn"><span>Sign In</span></a>
+            <button class="labkey-button primary signin-btn" type="button"><span>Sign In</span></button>
             <span class="registrationSection" hidden>
                 <a class="labkey-button" id="registerButton" href="login-register.view">Register</a>
             </span>
@@ -47,4 +48,4 @@
             document.getElementById('registerButton').href += '?returnUrl=' + encodeURIComponent(LABKEY.ActionURL.getParameter('returnUrl'));
         }
     });
-</script>
+</script>

devtools/test/src/org/labkey/test/tests/devtools/AuthenticationProviderReorderTest.java

@@ -51,7 +51,7 @@ public void testReorderConfigurations()
 
         signOut();
         assertSsoLinkOrder(config_uncool, config_cool);
-        clickAndWait(Locator.linkWithText("Sign In"));
+        clickAndWait(Locator.button("Sign In"));
         assertSsoLinkOrder(config_uncool, config_cool);
         simpleSignIn();
 
@@ -64,7 +64,7 @@ public void testReorderConfigurations()
 
         signOut();
         assertSsoLinkOrder(config_cool, config_uncool);
-        clickAndWait(Locator.linkWithText("Sign In"));
+        clickAndWait(Locator.button("Sign In"));
         assertSsoLinkOrder(config_cool, config_uncool);
         simpleSignIn();
     }

experiment/package.json

@@ -13,7 +13,7 @@
     "test-integration": "cross-env NODE_ENV=test jest --ci --runInBand -c test/js/jest.config.integration.js"
   },
   "dependencies": {
-    "@labkey/components": "7.38.0"
+    "@labkey/components": "7.39.0"
   },
   "devDependencies": {
     "@labkey/build": "9.1.3",

pipeline/package.json

@@ -14,7 +14,7 @@
     "build-prod": "npm run clean && cross-env NODE_ENV=production PROD_SOURCE_MAP=source-map webpack --config node_modules/@labkey/build/webpack/prod.config.js --color --progress --profile"
   },
   "dependencies": {
-    "@labkey/components": "7.38.0"
+    "@labkey/components": "7.39.0"
   },
   "devDependencies": {
     "@labkey/build": "9.1.3",