Skip to content

25.7 fb parentage evaluation#1526

Merged
Ohsudev merged 9 commits intorelease25.7-SNAPSHOTfrom
25.7_fb_ParentageEvaluation
Nov 3, 2025
Merged

25.7 fb parentage evaluation#1526
Ohsudev merged 9 commits intorelease25.7-SNAPSHOTfrom
25.7_fb_ParentageEvaluation

Conversation

@Ohsudev
Copy link
Copy Markdown
Collaborator

@Ohsudev Ohsudev commented Oct 28, 2025

Modified the program that determines the dam/sire values that populates the "Parent Information" from the
Animal Snapshot reports.

@Ohsudev Ohsudev requested a review from kollil October 28, 2025 20:25
@github-actions
Copy link
Copy Markdown

WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive.

kollil
kollil previously approved these changes Oct 28, 2025
@Ohsudev Ohsudev merged commit fab2c8d into release25.7-SNAPSHOT Nov 3, 2025
7 checks passed
@Ohsudev Ohsudev deleted the 25.7_fb_ParentageEvaluation branch November 3, 2025 22:59
@bbimber
Copy link
Copy Markdown
Collaborator

bbimber commented Nov 4, 2025

@brentlogan, @Ohsudev, and/or @kollil: I dont quite understand these changes. Specifically:

  1. It is almost always better practice to use the "coalesced" version of enddates, unless you have a very specific reason. The purpose of testing "p.enddateCoalesced <= now()", instead of what you changed it to be (enddate IS NULL), is that the former would correctly handle a future end dates. While I will grant that this situation is not likely in the case of parentage; however, there is value in consistency and in writing code that is robust to unexpected conditions.

  2. The original intend of this query was to report all parentage data. That means that if a given animal was reported with one dam, but genetic data contradicted this, they are nonetheless both returned. Other queries in EHR, demographicsParents.sql for example, coalesce between the sources of parentage and preferentially take genetic over observed parentage. The primary piece of code that seems to use parentageSummary is ParentsDemographicsProvider. What's driving the need for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants