Update procedure order status on death/departure#638
Merged
labkey-martyp merged 3 commits intorelease25.11-SNAPSHOTfrom Jan 12, 2026
Merged
Update procedure order status on death/departure#638labkey-martyp merged 3 commits intorelease25.11-SNAPSHOTfrom
labkey-martyp merged 3 commits intorelease25.11-SNAPSHOTfrom
Conversation
labkey-jeckels
approved these changes
Jan 7, 2026
Contributor
labkey-jeckels
left a comment
There was a problem hiding this comment.
I didn't do any testing on this but the code changes look good.
nirc_ehr/src/org/labkey/nirc_ehr/query/NIRC_EHRTriggerHelper.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Update procedure order status on death/departure to completed. This essentially closes the procedure order but is not necessarily indicating the procedure was done.
Also update the key on procedure schedule and reports so More Actions options will have consistent behavior there as on the prc order dataset.
Changes