Update to Gradle 9 and make more progress toward configuration cache compatibility

README.md

@@ -15,9 +15,27 @@ on how to do that, including how to develop and test locally and the versioning
 
 ### TBD
 *Released*: TBD
-(Earliest compatible LabKeyversion: 25.2)
+(Earliest compatible LabKey version: TBD)
 - Update `PurgeArtifacts` task to be compatible with configuration cache and to work with input files so archived projects can be kept up to date
 - Update dependency versions
+- Update DoThenSetup and its relatives to be compatible with configuration cache
+- Update DeployApp for better configuration cache compatibility
+- Replace usages of project.javaexc with JavaExc task types or injected ExecOperations
+- Update CompressClientLibs, StopLabKey to work better with configuration cache
+- Remove `listNodeModules` task defined by `NpmRun` plugin
+- Remove `cleanOut` task defined by `FileModule` plugin
+- Remove `cleanAndDeploy` task from `ServerDeploy` plugin
+- Update `CopyAndInstallRPackage` Task class to use injected FileSystem instead of `project.copy`
+- Update `GzipAction` task to use task logger and ant builder objects
+- Update `StopLabKey` and `StartLabKey` with appropriate dependencies to mirror the deprecated `StopTomcat` and `StartTomcat`
+- Remove deprecated `getServerDeployDirectory` from `ServerDeployExtension`
+- Remove `createNlpConfig` task from `TeamCity` plugin since that module is no longer in use
+- Remove `setup` task from `ServerDeploy` plugin.
+- Update `DeployDistribution` and `StageDistribution` for configuration cache compatibility
+- Some updates for `ModuleDistribution` for better configuration cache compatibility
+- Update `PropertiesUtils` to remove code for supporting `labkey.xml`
+- Relocate the `.restartTriggerFile` to prevent creation of empty `build/deploy/modules` directory for embedded distribution deployment
+- Fix `bootstrap` task so it will update `application.properties`
 
 ### 6.3.0
 *Released*: 3 July 2025

build.gradle

@@ -30,6 +30,7 @@ repositories {
 dependencies {
     implementation gradleApi()
     implementation localGroovy()
+    implementation "org.apache.groovy:groovy-sql:${groovySqlVersion}"
     api "org.apache.commons:commons-lang3:${commonsLang3Version}"
     api "org.apache.commons:commons-text:${commonsTextVersion}"
     api "commons-io:commons-io:${commonsIoVersion}"
@@ -42,7 +43,7 @@ dependencies {
 }
 
 group = 'org.labkey.build'
-project.version = "6.4.0-SNAPSHOT"
+project.version = "6.4.0-gradle9-SNAPSHOT"
 
 gradlePlugin {
     plugins {

gradle.properties

@@ -1,6 +1,6 @@
 artifactory_contextUrl=https://labkey.jfrog.io/artifactory
 
-artifactoryPluginVersion=5.2.5
+artifactoryPluginVersion=6.0.0
 
 commonsIoVersion=2.20.0
 commonsLang3Version=3.18.0
@@ -9,6 +9,8 @@ commonsTextVersion=1.14.0
 grgitGradleVersion=5.3.2
 graphqlJavaVersion=24.2
 
+groovySqlVersion=4.0.27
+
 httpclientVersion=5.5
 httpcoreVersion=5.3.4
 

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.0.0-bin.zip
 networkTimeout=10000
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME

src/main/groovy/org/labkey/gradle/plugin/ApplyLicenses.groovy

@@ -96,8 +96,9 @@ class ApplyLicenses implements Plugin<Project>
             }
 
             project.tasks.register('verifyLicensePatch') {
-                dependsOn(patchApiTask)
-                doLast {
+                it.group = GroupNames.TEST
+                it.dependsOn(patchApiTask)
+                it.doLast {
                     [project.configurations.extJs3Commercial, project.configurations.extJs4Commercial].forEach {
                         def commercialLicense = project.zipTree(it.singleFile).matching {
                             include '*/license.txt'
@@ -110,6 +111,7 @@ class ApplyLicenses implements Plugin<Project>
                         }
                     }
                 }
+                it.notCompatibleWithConfigurationCache("Needs to inject ArtifactOperations for zipTree usage")
             }
         }
     }

src/main/groovy/org/labkey/gradle/plugin/ClientLibraries.groovy

@@ -51,6 +51,7 @@ class ClientLibraries
                     task.dependsOn(project.tasks.processResources)
                     task.dependsOn(project.project(minProjectPath).tasks.named("npmInstall"))
                     task.xmlFiles = getLibXmlFiles(project)
+                    task.notCompatibleWithConfigurationCache("Class ClientLibsCompress needs more input and output properties declared")
             }
 
             project.evaluationDependsOn(minProjectPath)

src/main/groovy/org/labkey/gradle/plugin/Database.groovy

@@ -52,6 +52,7 @@ class Database implements Plugin<Project>
                 task.group = GroupNames.DATABASE
                 task.description = "Switch to SQL Server configuration"
                 task.dbType = "mssql"
+                task.driverFiles.setFrom(project.configurations.driver)
         }
     }
 
@@ -62,6 +63,7 @@ class Database implements Plugin<Project>
                 task.group = GroupNames.DATABASE
                 task.description = "Switch to SQL Server configuration using jTDS driver"
                 task.dbType = "jtds"
+                task.driverFiles.setFrom(project.configurations.driver)
         }
     }
 
@@ -71,6 +73,9 @@ class Database implements Plugin<Project>
             Bootstrap task ->
                 task.group = GroupNames.DATABASE
                 task.description = "Switch to bootstrap database properties as defined in current db.config file"
+                task.driverFiles.setFrom(project.configurations.driver)
+                task.dbPropertiesChanged = true
+                task.outputs.upToDateWhen({ return false })
         }
     }
 }

src/main/groovy/org/labkey/gradle/plugin/Distribution.groovy

@@ -29,6 +29,7 @@ import org.labkey.gradle.plugin.extension.DistributionExtension
 import org.labkey.gradle.plugin.extension.LabKeyExtension
 import org.labkey.gradle.plugin.extension.TeamCityExtension
 import org.labkey.gradle.task.ModuleDistribution
+import org.labkey.gradle.task.TeamCityPropertiesTask
 import org.labkey.gradle.util.BuildUtils
 import org.labkey.gradle.util.GroupNames
 import org.labkey.gradle.util.PomFileHelper
@@ -46,7 +47,7 @@ class Distribution implements Plugin<Project>
         // We add the TeamCity extension here if it doesn't exist because we will use the build
         // number property from TeamCity in the distribution artifact names, if present.
         TeamCityExtension teamCityExt  = project.getExtensions().findByType(TeamCityExtension.class)
-        if (TeamCityExtension.isOnTeamCity(project) && teamCityExt == null)
+        if (TeamCityPropertiesTask.isOnTeamCity(project) && teamCityExt == null)
             project.extensions.create("teamCity", TeamCityExtension, project)
 
         if (BuildUtils.getServerProject(project) != null) {
@@ -62,10 +63,6 @@ class Distribution implements Plugin<Project>
         addDependencies(project)
         addTasks(project)
         addTaskDependencies(project)
-
-        // commented out until we start publishing distribution artifacts, and then we'll examine the publications more closely
-//        if (BuildUtils.shouldPublishDistribution(project))
-//            addArtifacts(project)
     }
 
     private void addConfigurations(Project project)
@@ -169,74 +166,6 @@ class Distribution implements Plugin<Project>
                     project.dependencies.add("distribution", dep)
         }
     }
-
-    private void addArtifacts(Project project)
-    {
-        project.apply plugin: 'maven-publish'
-
-        // TODO this is really only an approximation of what's needed. We don't currently publish distribution artifacts
-        // to artifactory
-        project.afterEvaluate {
-            String artifactId = getArtifactId(project)
-            Properties pomProperties = LabKeyExtension.getApiPomProperties(artifactId, project.dist.description, project)
-            project.publishing {
-                publications {
-                    distributions(MavenPublication) { pub ->
-                        pub.artifactId(artifactId)
-                        project.tasks.each {
-                            if (it instanceof ModuleDistribution)
-                            {
-                                it.outputs.files.each {File file ->
-                                    pub.artifact(file)
-                                    {
-                                        String fileName = file.getName()
-                                        if (fileName.endsWith("gz"))
-                                            extension "tar.gz"
-                                        if (fileName.contains("-src."))
-                                            classifier "src"
-                                    }
-                                }
-                            }
-                        }
-                        pom {
-                            name = project.name
-                            description = pomProperties.getProperty("Description")
-                            url = PomFileHelper.LABKEY_ORG_URL
-                            developers PomFileHelper.getLabKeyTeamDevelopers()
-                            // TODO this should probably not always be Apache license
-//                            licenses pomUtil.getLicense()
-                            organization PomFileHelper.getLabKeyOrganization()
-//                            scm PomFileHelper.getLabKeyScm()
-                            // doesn't seem like these pom files will have any dependencies
-                        }
-                    }
-                }
-
-                project.artifactoryPublish {
-                    project.tasks.each {
-                        if (it instanceof ModuleDistribution)
-                        {
-                            dependsOn it
-                        }
-                    }
-                    publications('distributions')
-                }
-            }
-        }
-    }
-
-    static String getArtifactId(Project project)
-    {
-        if (project.dist.artifactId != null)
-            return project.dist.artifactId
-        else
-        {
-            return TaskUtils.getOptionalTask(project, "distribution")
-                    .filter(task -> task.get() instanceof ModuleDistribution)
-                    .map(task -> ((ModuleDistribution)task.get()).getArtifactId())
-                    .orElse(project.name)
-        }
-    }
 }
 
 

src/main/groovy/org/labkey/gradle/plugin/FileModule.groovy

@@ -137,19 +137,6 @@ class FileModule implements Plugin<Project>
                 task.outputs.cacheIf { false } // disable build caching. Has too many undeclared inputs.
         }
 
-        // This is added because Intellij started creating this "out" directory when you build through IntelliJ.
-        // It copies files there that are actually input files to the build, which causes some problems when later
-        // builds attempt to find their input files.
-        project.tasks.register("cleanOut", Delete) {
-            Delete task ->
-                task.group = GroupNames.BUILD
-                task.description = "removes the ${project.file('out')} directory created by Intellij builds"
-                task.configure({ Delete delete ->
-                    if (project.file("out").isDirectory())
-                        project.delete project.file("out")
-                })
-        }
-
         var moduleTask = project.tasks.register("module", Jar) {
             Jar jar ->
                 jar.group = GroupNames.MODULE
@@ -209,6 +196,12 @@ class FileModule implements Plugin<Project>
                 }
             }
 
+        project.tasks.named('deployModule')
+            {
+                notCompatibleWithConfigurationCache("Needs its own class to do the two copies (one to staging and one to deploy or possibly two Copy tasks chained together.")
+            }
+
+
         project.tasks.register('undeployModule', Delete) {
             Delete task ->
                 task.group = GroupNames.MODULE
@@ -230,9 +223,9 @@ class FileModule implements Plugin<Project>
                 task.doLast {
                     BuildUtils.updateRestartTriggerFile(project)
                 }
+                task.notCompatibleWithConfigurationCache("Does multiple deletes using project.delete. Should have its own class.")
         }
 
-
         project.tasks.register("reallyClean") {
             Task task ->
                 task.group = GroupNames.BUILD

src/main/groovy/org/labkey/gradle/plugin/JavaModule.groovy

@@ -157,10 +157,6 @@ class JavaModule implements Plugin<Project>
                     })
         }
 
-        project.tasks.named('populateExplodedLib') {
-            notCompatibleWithConfigurationCache("Need to figure out how to make the inputs from the optional tasks work.")
-        }
-
         project.tasks.named('module').configure {dependsOn(populateLib)}
         // We do this afterEvaluate to allow all dependencies to be declared before checking
         project.afterEvaluate({