Bulk edit support for clinical observations: category-dependent Observation/Score editor#1145
Merged
Merged
Conversation
labkey-bpatel
approved these changes
Jun 15, 2026
labkey-martyp
added a commit
to LabKey/nircEHRModules
that referenced
this pull request
Jun 16, 2026
…/Score editor (#706) ## Rationale Adds Selenium coverage for the new category-dependent Observation/Score editor in the clinical observations bulk edit dialog, introduced in the related ehrModules PR. ## Related Pull Requests - LabKey/ehrModules#1145 ## Changes - New `testObservationBulkEdit` in `NIRC_EHRTest` that bulk-edits observation rows and verifies the Observation/Score editor is rebuilt per the selected Category (lookup combo for Appetite, free text for Mass), stays enabled across category changes, clears stale values, and applies the submitted values to every selected row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The bulk edit dialog for the clinical observations grid offered only a plain text field for Observation/Score regardless of the selected Category, while the grid's cell editor adapts that field to the category's configured editor. This makes the bulk edit dialog offer the same category-dependent editor as the grid, so the data type and options match.
Related Pull Requests
Changes
EHR.plugin.ClinicalObservationsBulkEditplugin that rebuilds the Observation/Score field from the selected category'seditorconfig, preserving the field's enable/disable toggle state and re-registering it with the databind plugin.EHR.panel.BulkEditPanelaccepts panel plugins contributed viaformConfig.bulkEditPlugins, keeping the panel itself free of observation-specific logic; the label click-to-toggle behavior is extracted into a reusableaddLabelTogglemethod.EHR.grid.ClinicalObservationGridPanelregisters the new plugin through itsformConfig.hasLoadedOnceso consumers can distinguish a pending initial load from an empty result.