-
Notifications
You must be signed in to change notification settings - Fork 1
Copier update: base image #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,19 +1,22 @@ | ||||||
| # base image tags available at https://mcr.microsoft.com/v2/devcontainers/universal/tags/list | ||||||
| # added the platform flag to override any local settings since this image is only compatible with linux/amd64. since this image is only x64 compatible, suppressing the hadolint rule | ||||||
| # hadolint ignore=DL3029 | ||||||
| FROM --platform=linux/amd64 mcr.microsoft.com/devcontainers/universal:2.13.1-focal | ||||||
| FROM --platform=linux/amd64 mcr.microsoft.com/devcontainers/universal:5.1.1-noble | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: For
Citations: Remove The 🤖 Prompt for AI Agents |
||||||
|
|
||||||
| SHELL ["/bin/bash", "-o", "pipefail", "-c"] | ||||||
|
|
||||||
| # temporary hack until yarn updates its GPG key | ||||||
| RUN rm /etc/apt/sources.list.d/yarn.list || true | ||||||
|
||||||
| RUN rm /etc/apt/sources.list.d/yarn.list || true | |
| RUN rm -f /etc/apt/sources.list.d/yarn.list |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,11 +7,11 @@ | |
| import tempfile | ||
| from pathlib import Path | ||
|
|
||
| UV_VERSION = "0.9.17" | ||
| PNPM_VERSION = "10.25.0" | ||
| COPIER_VERSION = "9.11.0" | ||
| COPIER_TEMPLATE_EXTENSIONS_VERSION = "0.3.3" | ||
| PRE_COMMIT_VERSION = "4.5.0" | ||
| UV_VERSION = "0.9.26" | ||
| PNPM_VERSION = "10.28.1" | ||
| COPIER_VERSION = "==9.11.2" | ||
| COPIER_TEMPLATE_EXTENSIONS_VERSION = "==0.3.3" | ||
| PRE_COMMIT_VERSION = "4.5.1" | ||
|
Comment on lines
+10
to
+14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial 🧩 Analysis chain🏁 Script executed: # First, let's read the install-ci-tooling.py file to understand the full context
cat -n .devcontainer/install-ci-tooling.pyRepository: LabAutomationAndScreening/copier-python-package-template Length of output: 7394 Clarify version-specifier naming to prevent misuse.
Suggested change-COPIER_VERSION = "==9.11.2"
-COPIER_TEMPLATE_EXTENSIONS_VERSION = "==0.3.3"
+COPIER_SPEC = "==9.11.2"
+COPIER_TEMPLATE_EXTENSIONS_SPEC = "==0.3.3"
...
- f"copier{COPIER_VERSION}",
+ f"copier{COPIER_SPEC}",
...
- f"copier-template-extensions{COPIER_TEMPLATE_EXTENSIONS_VERSION}",
+ f"copier-template-extensions{COPIER_TEMPLATE_EXTENSIONS_SPEC}",🤖 Prompt for AI Agents |
||
| GITHUB_WINDOWS_RUNNER_BIN_PATH = r"C:\Users\runneradmin\.local\bin" | ||
| INSTALL_SSM_PLUGIN_BY_DEFAULT = False | ||
| parser = argparse.ArgumentParser(description="Install CI tooling for the repo") | ||
|
|
@@ -76,9 +76,9 @@ def main(): | |
| uv_path, | ||
| "tool", | ||
| "install", | ||
| f"copier=={COPIER_VERSION}", | ||
| f"copier{COPIER_VERSION}", | ||
| "--with", | ||
| f"copier-template-extensions=={COPIER_TEMPLATE_EXTENSIONS_VERSION}", | ||
| f"copier-template-extensions{COPIER_TEMPLATE_EXTENSIONS_VERSION}", | ||
| ], | ||
| check=True, | ||
| env=uv_env, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -156,7 +156,7 @@ jobs: | |
|
|
||
| - name: Upload Docker Image Artifact | ||
| if: ${{ inputs.save-as-artifact }} | ||
| uses: actions/upload-artifact@v5.0.0 | ||
| uses: actions/upload-artifact@v6.0.0 | ||
| with: | ||
| name: ${{ steps.calculate-build-context-hash.outputs.image_name_no_slashes }} | ||
| path: ${{ steps.calculate-build-context-hash.outputs.image_name_no_slashes }}.tar | ||
|
Comment on lines
+159
to
162
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: actions/upload-artifact v6.0.0 (released Dec 12, 2025) — release notes & breaking changes Breaking change / upgrade impact
What changed in v6.0.0
Sources: GitHub release page / repo docs for Verify self-hosted runner compatibility before upgrading to v6.0.0 (released Dec 12, 2025) introduces breaking changes:
If you use self-hosted runners, ensure they're updated before merging this change. GitHub-hosted runners are typically updated automatically and should be compatible. 🤖 Prompt for AI Agents |
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,3 +1,9 @@ | ||||||
| # Questions specific to this template | ||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
Comment on lines
+1
to
+6
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove excessive blank lines. YAMLlint flags 5 blank lines where maximum 2 are allowed. This appears to be unintentional whitespace at the top of the file. 🧹 Proposed fix # Questions specific to this template
-
-
-
-
-
# Questions managed by upstream template📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.38.0)[error] 6-6: too many blank lines (5 > 2) (empty-lines) 🤖 Prompt for AI Agents |
||||||
| # Questions managed by upstream template | ||||||
| repo_name: | ||||||
| type: str | ||||||
|
|
@@ -27,6 +33,11 @@ ssh_port_number: | |||||
| # Pick a random port, but ensure it's not in the excluded port range on Windows (powershell: `netsh int ipv4 show excludedportrange protocol=tcp`) | ||||||
| default: "{{ ( (range(49152, 49752) | list) + (range(49852, 50000) | list) + (range(50060, 50160) | list) + (range(50160, 50260) | list) + (range(50260, 50360) | list) + (range(50914, 51014) | list) + (range(51114, 51214) | list) + (range(51214, 51314) | list) + (range(51314, 51414) | list) + (range(51623, 51723) | list) + (range(51723, 51823) | list) + (range(65269, 65369) | list) + (range(65369, 65469) | list) ) | random }}" | ||||||
|
|
||||||
| pull_from_ecr: | ||||||
| type: bool | ||||||
| help: Will you need to pull images from a central AWS Elastic Container Registry? | ||||||
| default: no | ||||||
|
|
||||||
| use_windows_in_ci: | ||||||
| type: bool | ||||||
| help: Should CI in the instantiated template also use Windows runners? | ||||||
|
|
@@ -72,24 +83,24 @@ python_ci_versions: | |||||
| aws_identity_center_id: | ||||||
| type: str | ||||||
| help: What's the ID of your Organization's AWS Identity center, e.g. d-9145c20053? | ||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or install_aws_ssm_port_forwarding_plugin }}" | ||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or install_aws_ssm_port_forwarding_plugin or pull_from_ecr }}" | ||||||
|
|
||||||
| aws_org_home_region: | ||||||
| type: str | ||||||
| help: What is the home region of the AWS Organization (where all of the central infrastructure is deployed)? | ||||||
| default: us-east-1 | ||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or install_aws_ssm_port_forwarding_plugin }}" | ||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or install_aws_ssm_port_forwarding_plugin or pull_from_ecr }}" | ||||||
|
|
||||||
| aws_central_infrastructure_account_id: | ||||||
| type: str | ||||||
| help: What's the ID of your Organization's AWS Account containing Central Infrastructure (e.g. CodeArtifact)? | ||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' }}" | ||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or pull_from_ecr }}" | ||||||
| default: "000000000000" | ||||||
|
|
||||||
| core_infra_base_access_profile_name: | ||||||
| type: str | ||||||
| help: What's the AWS Identity Center Profile name for base access to the Central Infrastructure account (i.e. to read from CodeArtifact)? | ||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' }}" | ||||||
| when: "{{ python_package_registry == 'AWS CodeArtifact' or pull_from_ecr }}" | ||||||
| default: CoreInfraBaseAccess | ||||||
|
|
||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructions string refers to
super().init()which is not a valid Python initializer call; it should referencesuper().__init__()to avoid confusion.