Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR pulls in upstream changes to update workflow configurations and dependency versions, with a focus on enhancing Dependabot integration.
- Introduces a new workflow (get-values.yaml) to capture Dependabot commit details.
- Updates CI workflow templates to incorporate get-values outputs and correctly mark updated commits.
- Updates dependency versions for the Python setup action across multiple configuration files.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| template/.github/workflows/get-values.yaml | Adds a workflow to obtain new Dependabot SHA and commit status |
| template/.github/workflows/ci.yaml.jinja | Integrates the new get-values job output into CI and adjusts job dependencies |
| template/.github/dependabot.yml.jinja | Updates Dependabot configuration to ignore boto3 updates |
| template/.github/actions/install_deps_uv/action.yml | Bumps the actions/setup-python version to v5.6.0 |
| extensions/context.py | Updates the GitHub Actions version reference for python setup |
| .github/workflows/ci.yaml | Updates job naming and refines API call formatting for marking commits |
| .github/dependabot.yml | Mirrors the boto3 ignore change in the templated Dependabot config |
| .github/actions/install_deps_uv/action.yml | Mirrors the Python setup action version bump |
| .copier-answers.yml | Updates the commit hash for the Copier template |
Comment on lines
+168
to
+172
| needs: | ||
| - test | ||
| - get-values{% endraw %}{% if create_docs %} | ||
| - build-docs{% endif %}{% if is_frozen_executable %} | ||
| - executable{% endif %}{% raw %} |
There was a problem hiding this comment.
[nitpick] The mixing of raw and templating syntax in the 'needs:' block makes the logic harder to read and maintain; consider refactoring the templating logic for improved clarity.
Suggested change
| needs: | |
| - test | |
| - get-values{% endraw %}{% if create_docs %} | |
| - build-docs{% endif %}{% if is_frozen_executable %} | |
| - executable{% endif %}{% raw %} | |
| {% set required_needs = ["test", "get-values"] %} | |
| {% if create_docs %} | |
| {% set required_needs = required_needs + ["build-docs"] %} | |
| {% endif %} | |
| {% if is_frozen_executable %} | |
| {% set required_needs = required_needs + ["executable"] %} | |
| {% endif %} | |
| needs: {{ required_needs }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull in upstream changes