Skip to content

Copier update (dependabot more tweaks)#39

Merged
ejfine merged 5 commits intomainfrom
more-dep
May 9, 2025
Merged

Copier update (dependabot more tweaks)#39
ejfine merged 5 commits intomainfrom
more-dep

Conversation

@ejfine
Copy link
Copy Markdown
Contributor

@ejfine ejfine commented May 9, 2025

Pull in upstream changes

@ejfine ejfine requested a review from Copilot May 9, 2025 17:46
@ejfine ejfine self-assigned this May 9, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR pulls in upstream changes to update workflow configurations and dependency versions, with a focus on enhancing Dependabot integration.

  • Introduces a new workflow (get-values.yaml) to capture Dependabot commit details.
  • Updates CI workflow templates to incorporate get-values outputs and correctly mark updated commits.
  • Updates dependency versions for the Python setup action across multiple configuration files.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
template/.github/workflows/get-values.yaml Adds a workflow to obtain new Dependabot SHA and commit status
template/.github/workflows/ci.yaml.jinja Integrates the new get-values job output into CI and adjusts job dependencies
template/.github/dependabot.yml.jinja Updates Dependabot configuration to ignore boto3 updates
template/.github/actions/install_deps_uv/action.yml Bumps the actions/setup-python version to v5.6.0
extensions/context.py Updates the GitHub Actions version reference for python setup
.github/workflows/ci.yaml Updates job naming and refines API call formatting for marking commits
.github/dependabot.yml Mirrors the boto3 ignore change in the templated Dependabot config
.github/actions/install_deps_uv/action.yml Mirrors the Python setup action version bump
.copier-answers.yml Updates the commit hash for the Copier template

Comment on lines +168 to +172
needs:
- test
- get-values{% endraw %}{% if create_docs %}
- build-docs{% endif %}{% if is_frozen_executable %}
- executable{% endif %}{% raw %}
Copy link

Copilot AI May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The mixing of raw and templating syntax in the 'needs:' block makes the logic harder to read and maintain; consider refactoring the templating logic for improved clarity.

Suggested change
needs:
- test
- get-values{% endraw %}{% if create_docs %}
- build-docs{% endif %}{% if is_frozen_executable %}
- executable{% endif %}{% raw %}
{% set required_needs = ["test", "get-values"] %}
{% if create_docs %}
{% set required_needs = required_needs + ["build-docs"] %}
{% endif %}
{% if is_frozen_executable %}
{% set required_needs = required_needs + ["executable"] %}
{% endif %}
needs: {{ required_needs }}

Copilot uses AI. Check for mistakes.
@ejfine ejfine merged commit 0336307 into main May 9, 2025
8 checks passed
@ejfine ejfine deleted the more-dep branch May 9, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants