Skip to content

Fix Staging CI job#20

Merged
ejfine merged 5 commits intomainfrom
comment-on-pr
Mar 30, 2026
Merged

Fix Staging CI job#20
ejfine merged 5 commits intomainfrom
comment-on-pr

Conversation

@ejfine
Copy link
Copy Markdown
Contributor

@ejfine ejfine commented Mar 30, 2026

Why is this change necessary?

Comment wasn't being made on PR, deployment wasn't happening on main

How is this change tested?

Downstream repo

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to optimize staging deployment behavior: deployments to staging now execute only when changes are pushed to the main branch, not during pull requests.
    • Added pull request preview comments for staging deployments.
    • Improved workflow job naming for better clarity.

@ejfine ejfine self-assigned this Mar 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 673ffbd0-c479-4258-94f2-7b6e38ba1da7

📥 Commits

Reviewing files that changed from the base of the PR and between f71d38c and 813e704.

📒 Files selected for processing (1)
  • template/.github/workflows/ci.yaml.jinja

📝 Walkthrough

Walkthrough

The staging Pulumi job in the CI workflow was renamed from plan-to-staging to pulumi-staging. The PULUMI_UP input is now conditionally set based on the branch being refs/heads/main rather than hard-coded to false. A new SHOW_PREVIEW_COMMENT_ON_PR input was added for pull request events. All downstream job dependencies were updated accordingly.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
template/.github/workflows/ci.yaml.jinja
Renamed staging job from plan-to-staging to pulumi-staging. Updated PULUMI_UP to conditionally enable on main branch (${{ github.ref == 'refs/heads/main' }}). Added SHOW_PREVIEW_COMMENT_ON_PR input tied to pull request events. Updated pulumi-prod job dependencies and workflow-summary references to use the new job name.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Deploy in CI #9: Modifies the same CI workflow file with overlapping changes to staging job configuration and Pulumi deployment wiring.
  • CI Fix #17: Modifies the staging job in the same CI workflow file with adjustments to job inputs and configuration.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers only 2 of 6 required template sections; 'Link to Issue', 'Side effects', and 'Other' are missing, and included sections lack sufficient detail. Complete the pull request description by adding missing sections: link to the related issue/thread, explanation of side effects, and any other relevant notes; provide more context for why the changes (PULUMI_UP and SHOW_PREVIEW_COMMENT_ON_PR) fix the identified problems.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix Staging CI job' clearly summarizes the main change—addressing issues with the staging job in the CI workflow (comment not being made on PR and deployment not happening on main).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ejfine ejfine marked this pull request as ready for review March 30, 2026 17:25
@ejfine ejfine merged commit b9c1e94 into main Mar 30, 2026
23 checks passed
@ejfine ejfine deleted the comment-on-pr branch March 30, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant