specifying a cache value we must not use ALWAYS unless its NO CACHE#137
specifying a cache value we must not use ALWAYS unless its NO CACHE#137
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdjusted Nginx add_header directives in the frontend template: removed Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@zendern - any concerns about adding
If not, can you make that change here real quick |
Why is this change necessary?
We do want
alwayson the NO CACHE scenarios so that it never caches but for this one where we are trying to make sure it caches we dont want it b/c we could end up caching errors when we dont want that behavior. I missed it when it suggested this change. 420e88bHow does this change address the issue?
Removes the
alwaysflag on the nuxt static resourcesWhat side effects does this change have?
N/A
How is this change tested?
N/A
Summary by CodeRabbit