Update tree ring parameters based on LSSTCam data#516
Open
Update tree ring parameters based on LSSTCam data#516
Conversation
add function to update tree ring parameters add access to the derivative of the distortion function, which gives the expected pixel counts modulation
8e16aa0 to
09734c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I've performed the following steps to update the model tree ring parameters for each science CCD:
data_std, of the LSSTCam pixel values in the radius range 4500-5200 pixel units. This will be used as a measure of the tree ring amplitudes.tree_ring_parameters_2018-04-26.txt) for the CCD at issue evaluated at the same radius locations as the LSSTCam data.model_std, of the tree ring model profiles in the 4500-5200 radius range.AandBparameters of the tree ring model radial scaling function,A + B * r**4, by the ratiodata_std/model_std. The rescaledAandBvalues are updated in the new tree ring parameter model.tree_ring_parameters_2026-04-02.txt.This procedure has been implemented in the
refit_treerings.pyscript. I've updated thetreerings.pymodule to provide access to the derivative of the pixel distortion function,dfdr, which is the predicted pixel count modulation from the effect of the tree ring distortions. I've also added interfaces to update the tree ring parameters and to write the modified model to a text file with the expected format.The following plots show the boxcar smoothed LSSTCam tree ring profiles (blue curves) for a selection of LSSTCam CCDs, compared with the rescaled model profiles (orange curves). The vertical dotted lines indicate the range over which the standard deviations were computed for the LSSTCam data and the model profiles. The corner legend shows the scaling factor that was applied to the A and B parameters.


The plot below shows the measured tree ring profile from a simulated flat using the new parameters (blue curve) with the corresponding model prediction overlaid (orange curve).
