Skip to content

test_image.py expected fluxes and assertion #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
welucas2 merged 5 commits into from
Mar 24, 2026
+26 −22
Merged

test_image.py expected fluxes and assertion #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f33fdc
test_image checks whether fluxes are more than 4*sigma out from a mea…
welucas2 Mar 10, 2026
0e4012a
Pytest is verbose in CI to find which test is failing.
welucas2 Mar 17, 2026
4ee6cb5
Use Ubuntu 22.04 runner rather than latest in CI.
welucas2 Mar 17, 2026
7431e19
Move back to ubuntu-latest; single pytest worker.
welucas2 Mar 17, 2026
3b027fa
Apply suggestion from @rmjarvis
rmjarvis Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
setup -r skyCatalogs -j
eups list | grep LOCAL
galsim --version
pytest --durations=10 -n auto
pytest --durations=10 -n 1 -v
Copy link
Copy Markdown
Collaborator

@jchiang87 jchiang87 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest we remove the -v, but looking at the output, it's not as verbose as I feared, and it seems more useful to be able to see more than just the .s in case we continue to have the "The operation was canceled" outcomes.

Copy link
Copy Markdown
Contributor

@rmjarvis rmjarvis Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always run with -v on CI. It's easier to see where something failed if the code crashes.


- name: Check example config files
run: |
Expand Down
46 changes: 25 additions & 21 deletions tests/test_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,17 @@
STAMP_SIZE = 1000

def assert_objects_at_positions(image, expected_positions, expected_brightness_values, pixel_radius=10, rtol=0.1):
"""Sum the brightness values of squares of side length `2*pixel_radius` centered at `expected_positions` and compare against `expected_brightness_values`."""
"""Sum the brightness values of squares of side length `2*pixel_radius` centered
at `expected_positions` and compare against `expected_brightness_values` where the
maximum allowed difference is 4 * sqrt(expected)."""
brightness_values = np.empty_like(expected_brightness_values)
sigma = 4. * np.sqrt(expected_brightness_values)
for i, (col, row) in enumerate(expected_positions):
neighbourhood = image[row-pixel_radius:row+pixel_radius, col-pixel_radius:col+pixel_radius]
brightness_values[i] = np.sum(neighbourhood)
print("Object: ", i, expected_brightness_values[i], brightness_values[i])
np.testing.assert_allclose(brightness_values, expected_brightness_values, rtol=rtol)
print("Object: ", i, expected_brightness_values[i], brightness_values[i], sigma[i])
brightness_difference = np.abs(brightness_values - expected_brightness_values)
np.testing.assert_array_equal(brightness_difference <= sigma, True)


def create_test_config(
Expand Down Expand Up @@ -197,26 +201,26 @@ def run_lsst_image(image_type, stamp_type):
[3452, 3751],
])
expected_brightness_values = np.array([
1.974843e+06,
4.325211e+06,
1.974717e+06,
4.329067e+06,
0.0,
1.978054e+06,
1.973144e+06,
1.981440e+06,
1.971714e+06,
1.971509e+06,
1.976528e+06,
0.0,
3.131857e+06,
1.980739e+06,
1.977764e+06,
1.983800e+05,
4.045435e+06,
2.195470e+06,
4.045435e+06,
1.974780e+05,
1.966890e+05,
1.968660e+05,
1.970680e+05,
1.965050e+05,
4.000000e+01,
3.125554e+06,
1.978627e+06,
1.977857e+06,
1.977190e+05,
4.049977e+06,
2.192697e+06,
4.329907e+06,
1.971800e+05,
1.964360e+05,
1.970330e+05,
1.970620e+05,
1.965160e+05,
3.800000e+01,
])
assert_objects_at_positions(image.array, expected_positions, expected_brightness_values)

Expand Down
Loading