Skip to content

Remove update() from the L5 lifecycle #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
triss wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −8
Draft

Remove update() from the L5 lifecycle #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions L5.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ function love.run()
-- Update dt
if love.timer then dt = love.timer.step() end

-- Update
if love.update then love.update(dt) end
-- Refresh per-frame framework state (mouse position, deltaTime, key, video looping)
L5_internal.updateFrameState(dt)

-- Draw with double buffering
if love.graphics and love.graphics.isActive() then
love.graphics.origin()
Expand Down Expand Up @@ -164,7 +164,10 @@ function love.load()
fill(255)
end

function love.update(dt)
-- Per-frame framework bookkeeping (mouse position, deltaTime, key, video
-- looping). update() is not part of the L5 lifecycle - only setup() and
-- draw() are - so this is purely internal plumbing, not a user callback.
function L5_internal.updateFrameState(dt)
mouseX, mouseY = love.mouse.getPosition()
movedX=mouseX-pmouseX
movedY=mouseY-pmouseY
Expand All @@ -182,9 +185,6 @@ function love.update(dt)
end
end
end

-- Optional update (not typically Processing-like but available)
if update ~= nil then update() end
end

function love.draw()
Expand Down Expand Up @@ -849,7 +849,7 @@ function L5_internal.defaults()
TRIANGLE_STRIP = "strip"

-- global user vars - can be read by user but shouldn't be altered by user
key = "" --default, overriden with key presses detected in love.update(dt)
key = "" --default, overriden with key presses detected in L5_internal.updateFrameState(dt)
width = 800 --default, overridden with size() or fullscreen()
height = 600 --ditto
frameCount = 0
Expand Down