This repository was archived by the owner on Mar 23, 2023. It is now read-only.
Adds heartbeat to prevent Websocket closing#13
Open
RobertLowe wants to merge 1 commit intoKurento:masterfrom
RobertLowe:patch-1
Open
Adds heartbeat to prevent Websocket closing#13RobertLowe wants to merge 1 commit intoKurento:masterfrom RobertLowe:patch-1
RobertLowe wants to merge 1 commit intoKurento:masterfrom
RobertLowe:patch-1
Conversation
This change ensures Firefox (and others?) don't close connection when detected as idle with a CloseEvent of 1006. This is an opinionated change due to when using `ws.onclose` on the client. This is entirely committed for note and posterity.
|
Hi there. Thanks for your PR. I'm waiting for a Kurento member to verify that this patch is reasonable to test. If it is, they should reply with |
|
There were no errors, go have a cup of coffee... |
1 similar comment
|
There were no errors, go have a cup of coffee... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures Firefox (and others?) don't close connection when detected as idle with a CloseEvent of 1006. This is an opinionated change due to when using
ws.oncloseon the client. This is entirely committed for note and posterity.Cheers