Substitute type parameters with type arguments in toDataFrame conversion#1772
Open
Substitute type parameters with type arguments in toDataFrame conversion#1772
Conversation
Jolanrensen
reviewed
Mar 27, 2026
| internal fun KType.typeParametersSubstitution(): Map<KTypeParameter, KType> { | ||
| val klass = classifier as? KClass<*> ?: return emptyMap() | ||
| return klass.typeParameters.zip(arguments).mapNotNull { (param, projection) -> | ||
| projection.type?.let { param to it } |
Collaborator
There was a problem hiding this comment.
there seems to be a failing test regarding nullable int arrays not being recognized as nullable now, please check
Jolanrensen
reviewed
Mar 27, 2026
|
|
||
| fun DataFrame<*>.shouldHaveFrameColumn( | ||
| name: String, | ||
| block: (FrameColumn<*>) -> Unit = { |
Collaborator
There was a problem hiding this comment.
I'd simply write this as = {},, this multiline looks a bit odd
Jolanrensen
reviewed
Mar 27, 2026
| }, | ||
| ): ColumnGroup<*> = getColumnOrNull(name).shouldBeInstanceOf<ColumnGroup<*>>(block) | ||
|
|
||
| fun DataFrame<*>.shouldHaveFrameColumn( |
Collaborator
There was a problem hiding this comment.
these are cool! :) maybe put them somewhere in a utils file though, that way we can reuse them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1771
Includes little experiment with custom asserters for dataframe shape