Add column selector overloads for GroupBy.sortByKey#1768
Open
mvanhorn wants to merge 1 commit intoKotlin:masterfrom
Open
Add column selector overloads for GroupBy.sortByKey#1768mvanhorn wants to merge 1 commit intoKotlin:masterfrom
mvanhorn wants to merge 1 commit intoKotlin:masterfrom
Conversation
Adds ColumnsSelector overloads for sortByKey and sortByKeyDesc so users can specify which key columns to sort by instead of sorting by all keys with the same order. Fixes Kotlin#1523
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ColumnsSelectoroverloads forsortByKeyandsortByKeyDescso users can specify which key columns to sort by.Why this matters
The existing
sortByKey()sorts by all key columns with the same order. If you group bynameandagebut only want to sort byage, there's no way to express that without dropping down to rawsortBy.Changes
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/sort.kt: Added two new overloads acceptingColumnsSelector<T, C>, following the same pattern asGroupBy.sortBy(selector).Testing
sortBy/sortByDescoverloads that acceptSortColumnsSelectorFixes #1523
This contribution was developed with AI assistance (Claude Code).