Skip to content

Added flexibility for seed checking and 3 more multispawners#50

Open
Boombaastical wants to merge 9 commits intoKoi-3088:KoiTestfrom
Boombaastical:AddedOptions
Open

Added flexibility for seed checking and 3 more multispawners#50
Boombaastical wants to merge 9 commits intoKoi-3088:KoiTestfrom
Boombaastical:AddedOptions

Conversation

@Boombaastical
Copy link
Copy Markdown

Hello!

The changes are the follows:
-Increased the list, added a few combinations for multi exceptions, so that spawners such as Starly / Chimchar or Bidoof / Drifloon would be allowed for a seed check (as those combinations may happen, whether for regular multispawners or variable multispawners): the current implementation only supports a limited number of exceptions. I also ordered them by day first, then night, day ordered alphabetically.
-Added 2 more multispawners:
--Buizel 2-2 in Obsidian Fieldlands (so that gender matches not only for this but also other multispawners that can use this one instead of Combee)
--Tentacool / Tentacruel / Drifloon / Drifblim 3-3 in Cobalt Coastlands
--Swinub / Piloswine / Duskull / Dusclops 2-2 in Alabaster Icelands: same as the current spawner, only that it is for Night instead of day, allowing to hunt also Duskull / Dusclops through the bot

@Koi-3088
Copy link
Copy Markdown
Owner

Thanks for the PR! Left some comments, the missing commas will cause build errors. The ushort[] multiexceptions array needs duplicates removed and some sorting. It's laid out based on the order of the FakeSlots spawner order sans dupes - easier to follow and add.

@Koi-3088
Copy link
Copy Markdown
Owner

Koi-3088 commented Mar 29, 2026

The extra additions to ushort[] multiExceptions are also a bit questionable to me without the proper spawner tables backing them.

@Boombaastical
Copy link
Copy Markdown
Author

Boombaastical commented Mar 29, 2026

Thank you for the review!

Thanks for the PR! Left some comments, the missing commas will cause build errors. The ushort[] multiexceptions array needs duplicates removed and some sorting. It's laid out based on the order of the FakeSlots spawner order sans dupes - easier to follow and add.

For this, strange that there were missing commas, I'll check them out a bit again, sorry for that. I understand the ordering indeed, I'll move the order back to how it was then, while adding new ones.

The extra additions to ushort[] multiExceptions are also a bit questionable to me without the proper spawner tables backing them.

So the thing is that since more and more people start to do variable multispawners with Teal, this is an in-between change that may benefit hunting them a lot (and the new 3 regular multispawners, as they would need them). Basically, the modified list is based on all the available and potential multispawners that are on each map.

I made sure that this was also the bare minimum to make sure that we do not add any kind of species so as to let anyone randomly seed check without actually having done their homework about what can be seed-checked and what can't.

@Boombaastical
Copy link
Copy Markdown
Author

Boombaastical commented Mar 29, 2026

As I changed the species back to the original order, I also suddenly understood the logic, so I just updated it and here is the newest commit. Also added the missing commas. With these changes, I hope that people who use Teal can enjoy more the hunt in different kinds of ways, adding flexibility to their hunt. I think in the end it can only just benefit SHA more this way.

Here is the link for why I added each multispawner species

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants