Skip to content

Remove unneeded files#34

Merged
Kocal merged 1 commit into
Kocal:mainfrom
jmsche:remove-unneeded-files
Aug 26, 2025
Merged

Remove unneeded files#34
Kocal merged 1 commit into
Kocal:mainfrom
jmsche:remove-unneeded-files

Conversation

@jmsche

@jmsche jmsche commented Aug 25, 2025

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? no
Tests pass? I guess
Fixed tickets N/A

I guess these were forgotten during cleanup? 😅

@Kocal

Kocal commented Aug 26, 2025

Copy link
Copy Markdown
Owner

Nope they are needed in the CI, they must be ignored in the .gitattributes instead

@jmsche

jmsche commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

I haven't found any references to these files in the CI, and it seems the CI passes?

@Kocal

Kocal commented Aug 26, 2025

Copy link
Copy Markdown
Owner

Mmmh indeed, in E2E tests Biome runs on a new Symfony app and not fixtures file, they are purely internal.

Well, let's remove them, thanks!

PS: the same issue exists in https://github.com/Kocal/OxlintBundle if you want to become a contributor :p

@Kocal Kocal merged commit f5b4f72 into Kocal:main Aug 26, 2025
19 of 20 checks passed
@jmsche jmsche deleted the remove-unneeded-files branch August 26, 2025 11:22
@jmsche

jmsche commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

I'll have a look this week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants