Conversation
Signed-off-by: Jonathan <jplam12345@gmail.com>
Signed-off-by: Jonathan <jplam12345@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 27 27
Lines 6671 6672 +1
=======================================
+ Hits 5569 5570 +1
Misses 1102 1102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Kaspiaan
left a comment
Kaspiaan
left a comment
There was a problem hiding this comment.
Please change changelog to show this is an update to the rfr cog
JayDwee
left a comment
JayDwee
left a comment
There was a problem hiding this comment.
Just one change, and what Kieran has already mentioned
| role: discord.Role = discord.utils.get(guild.roles, id=guild.id) | ||
| overwrite: discord.PermissionOverwrite = discord.PermissionOverwrite() | ||
| overwrite.update(add_reactions=False) | ||
| await channel.set_permissions(role, overwrite=overwrite) | ||
| perms = channel.overwrites_for(role) |
There was a problem hiding this comment.
All current roles should have the add_reactions perm set to false, not just everyone. (although this successfully doesn't screw with other perms, as mentioned in issue, gj!)
3 participants
Signed-off-by: Jonathan jplam12345@gmail.com
Summary
fixes bug where it would default permissions if a rfr is created close #196
Checklist
CHANGELOG.mdunder the[Unreleased]heading?documentation.json?