Fixed: Bug #196 permissions reset when creating rfr

[jplam123]

Signed-off-by: Jonathan jplam12345@gmail.com

Summary

fixes bug where it would default permissions if a rfr is created close #196

Checklist

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed)
• This PR is not a code change (e.g. documentation, README, ...)

• Have you tested the changes? (pytest & dpytest)
• Have you followed PEP-8 for naming and styling?
• Has your code been properly documented with RestructuredText docstrings?
• Have you added your changes to CHANGELOG.md under the [Unreleased] heading?
• If your code added new bot commands, have you updated documentation.json?

• All of this code is your own, or follows the author repo's licence.

[codecov]

Codecov Report

Merging #239 (781bcde) into master (baf65a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files          27       27           
  Lines        6671     6672    +1     
=======================================
+ Hits         5569     5570    +1     
  Misses       1102     1102           

Flag	Coverage Δ
unittests	83.48% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cogs/ReactForRole.py	54.10% <100.00%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baf65a6...781bcde. Read the comment docs.

[Kaspiaan]

Please change changelog to show this is an update to the rfr cog

[JayDwee]

Just one change, and what Kieran has already mentioned

[JayDwee]

All current roles should have the add_reactions perm set to false, not just everyone. (although this successfully doesn't screw with other perms, as mentioned in issue, gj!)

[JayDwee]

Looks like @jplam123 won't be continuing with us, please reassign @Kaspiaan