Update list repositories methods in Teams and Apps API.#1067
Open
raghavendra89 wants to merge 2 commits intoKnpLabs:masterfrom
Open
Update list repositories methods in Teams and Apps API.#1067raghavendra89 wants to merge 2 commits intoKnpLabs:masterfrom
raghavendra89 wants to merge 2 commits intoKnpLabs:masterfrom
Conversation
acrobat
requested changes
Aug 1, 2022
Collaborator
acrobat
left a comment
acrobat
left a comment
There was a problem hiding this comment.
Thanks for your PR @raghavendra89! There are a few unnecessary changes and BC breaks that need to be fixed before we can merge the PR.
| * @return array | ||
| */ | ||
| public function listRepositories($userId = null) | ||
| public function listRepositories(array $params = []) |
Collaborator
There was a problem hiding this comment.
We can't remove/replace parameters as this would be a BC break. If the user parameter is not required anymore this should be deprecated so that we can remove it in the next major version
Comment on lines
+146
to
+149
| $parameters = array_merge([ | ||
| 'page' => 1, | ||
| 'per_page' => 30, | ||
| ], $params); |
Collaborator
There was a problem hiding this comment.
This should not be needed as the ResultPager class should be used to loop over multiple pages of results
Comment on lines
+111
to
+114
| $parameters = array_merge([ | ||
| 'page' => 1, | ||
| 'per_page' => 30, | ||
| ], $params); |
Collaborator
There was a problem hiding this comment.
This should not be needed as the ResultPager class should be used to loop over multiple pages of results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
repositoriesmethod in Teams api to support the new end point. Added params argument for AppslistRepositoriesmethod and Teamsrepositoriesmethod.