Skip to content

Add a rule-group id property to rule objects #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlschroedl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a rule-group id property to rule objects #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31c7a0b
patch to permit observables' rule objects to have a unique ID
carlschroedl Feb 18, 2013
b55ec9f
Merge branch 'master' of github.com:ericmbarnard/Knockout-Validation
carlschroedl Mar 4, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Src/knockout.validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,12 +373,13 @@
// }
// )};
//
if (params.message || params.onlyIf) { //if it has a message or condition object, then its an object literal to use
if (params.message || params.onlyIf || params.constraintGroupId) { //if it has a message or condition object, then its an object literal to use
return exports.addRule(observable, {
rule: ruleName,
message: params.message,
params: utils.isEmptyVal(params.params) ? true : params.params,
condition: params.onlyIf
condition: params.onlyIf,
constraintGroupId: params.constraintGroupId
});
} else {
return exports.addRule(observable, {
Expand Down