ENH: Modernize Qt integration in LayerDM tests#3
Merged
Thibault-Pelletier merged 1 commit intoKitwareMedical:mainfrom Feb 6, 2026
Merged
Conversation
- Replace manual QT5_GENERATE_MOCS with AUTOMOC - Use find_package with Qt version detection (Qt5/Qt6) - Simplify target linking with loop over Qt components - Update moc include to use .moc extension convention - Remove explicit Qt component dependencies in favor of dynamic linking This change makes the test configuration more maintainable and prepares the module for Qt6 compatibility.
Collaborator
|
Thx for the PR, it looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the test configuration more maintainable and prepares the module for Qt6 compatibility.