fix(TextActor): add support for property change#3447
Open
daker wants to merge 1 commit intoKitware:masterfrom
Open
fix(TextActor): add support for property change#3447daker wants to merge 1 commit intoKitware:masterfrom
daker wants to merge 1 commit intoKitware:masterfrom
Conversation
jourdain
reviewed
Mar 25, 2026
jourdain
reviewed
Mar 25, 2026
finetjul
reviewed
Mar 25, 2026
| } | ||
|
|
||
| if (property) { | ||
| model.propertySubscription = property.onModified(() => { |
Member
There was a problem hiding this comment.
vtk.js philosophy is not so much to "update" itself as a reaction to changes. Instead, it should wait to be rendered to update itself.
@sankhesh what event can trigger a texture refresh ?
daker
force-pushed
the
fix-textactor
branch
2 times, most recently
from
59528e4 to
4fd7a45
Compare
finetjul
reviewed
Mar 25, 2026
|
|
||
| if (property) { | ||
| propertySubscription = property.onModified(() => { | ||
| if (model.input !== undefined) { |
Member
There was a problem hiding this comment.
if input was valid and becomes invalid, it should probably clear the texture hence it must be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3445
Context
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting