feat(Build): modernize build and test tooling with Vite/Vitest & oxlint/oxfmt#3435
feat(Build): modernize build and test tooling with Vite/Vitest & oxlint/oxfmt#3435daker wants to merge 9 commits intoKitware:masterfrom
Conversation
65d7ab0 to
825c998
Compare
|
@jourdain if you skip the changes in the test files that should pass, it will reduce the number of changes that need to be reviewed. |
|
BTW, how long does the test takes to run with vitest? |
finetjul
left a comment
There was a problem hiding this comment.
J'ai tout review sauf package-lock.json
LGTM
Sources/Rendering/Core/HardwareSelector/test/testHardwareSelectorSpeed.js
Show resolved
Hide resolved
dfa94d2 to
a9bdd89
Compare
| return { | ||
| name: 'vtk-serve-data', | ||
| configureServer(server) { | ||
| server.middlewares.use('/Data', (req, res, next) => { |
There was a problem hiding this comment.
I think we serve /data lower case rather that /Data
There was a problem hiding this comment.
Remember, you had to fix that for the website / examples online.
| @@ -27,13 +27,12 @@ | |||
| "url": "https://github.com/kitware/vtk-js/issues" | |||
| }, | |||
| "homepage": "https://github.com/kitware/vtk-js#readme", | |||
| "main": "./dist/umd/vtk.js", | |||
There was a problem hiding this comment.
can't Vite also generate a umd format too? It can be ok to discontinue umd but we need to let the community know. I think you've updated the doc to promote esm usage as script.
Maybe that is enough. What do you think @finetjul ?
There was a problem hiding this comment.
Projects that are still using the UMD package :
https://github.com/openUC2/ImSwitch
https://github.com/sandialabs/slycat
There was a problem hiding this comment.
I do not realize how much work it is to keep umd builds. If it is challenging, ok to drop it.
If we drop umd, the PR should be considered as a breaking change (new major) and documented (in BREAKING_CHANGES.md how to move from umd to esm).
|
LGTM, @finetjul I let you merge it. I put some comments as I did not tested. |
|
Should we try to rebase? What is preventing us to merge that PR? |
|
@jourdain i can try to bring back the umd build with vite but we need to test the builds to see if nothing is broken. |
|
@finetjul would you be able to test the build? |
not before next week |
f651a58 to
68d34ac
Compare
68d34ac to
ed7c3c4
Compare
6f5a9ab to
39c691d
Compare

Context
This PR completes a tooling migration from the legacy webpack/rollup + Karma/Tape setup to a unified Vite + Vitest stack. It updates local development, build output, test execution, and CI integration to run on the new toolchain.
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting