Skip to content

Only Update MetadatFields on UpdateJob, not Status #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryonLewis merged 1 commit into from
Jul 6, 2026
Merged

Only Update MetadatFields on UpdateJob, not Status #1740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions server/dive_server/crud_rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,19 @@ def _persist_async_job_metadata(
Save DIVE-specific fields on a Celery job without clobbering worker status.

GirderAsyncResult.job caches the document from first access (typically INACTIVE).
Job().save() on that stale dict can race with the worker task_prerun RUNNING update
and leave the job stuck INACTIVE, which breaks later PUSHING_OUTPUT transitions.
Job().save() on that dict can race with the worker task_prerun RUNNING update:
load(INACTIVE) -> worker sets RUNNING -> save(INACTIVE) leaves the job stuck
INACTIVE, which breaks FETCHING_INPUT / PUSHING_OUTPUT transitions.
"""
job = Job().load(async_result.job['_id'], force=True)
for key, value in metadata.items():
job[key] = value
other_fields = dict(metadata)
if access_source is not None:
Job().copyAccessPolicies(access_source, job)
job = Job().save(job)
other_fields['public'] = job.get('public', False)
if 'access' in job:
other_fields['access'] = job['access']
job = Job().updateJob(job, otherFields=other_fields, notify=False)
job = Job().load(job['_id'], force=True)
async_result._job = job
return job

Expand Down
Loading