Fix interactive service launch on system-python builds and surface failures#1728
Merged
Merged
Conversation
…ace failures Fall back to the PATH python interpreter when bin/python is absent and use -s instead of -I so the PYTHONPATH set by setup_viame.sh is preserved. Report stereo segmentation match failures and service-launch failures to the user instead of failing silently.
BryonLewis
approved these changes
Jun 30, 2026
BryonLewis
left a comment
Collaborator
There was a problem hiding this comment.
Tested locally, mostly looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The unified interactive service (segmentation + stereo) failed to launch on VIAME builds that use the system Python interpreter rather than a bundled one, and several failure modes degraded silently instead of being reported to the user. This addresses both.
Launch fixes
bin/pythonfallback (linux.ts) —getViamePythonExe()hard-coded<viamePath>/bin/python, which only exists in bundled binary installs. From-source builds against system Python have no such interpreter (they rely onPYTHONPATHset bysetup_viame.sh). It now uses the bundled interpreter when present and otherwise falls back topythonon PATH. Windows is unchanged.-I→-s(interactive.ts) — the service was spawned withpython -I, but isolated mode implies-E, which discardsPYTHONPATH, soviamecould not be imported (No module named 'viame'). Switched to-s(ignore the per-user site dir, but keepPYTHONPATH). The original intent of-I(avoid a stray cwd entry shadowing packages) is already covered because the process cwd is forced toviamePath, which has no shadowing modules.Error surfacing
interactive.ts,api.ts,ViewerLoader.vue) — the stereo service watcher auto-runs on dataset load (not user-initiated) and previously degraded all failures silently so that uncalibrated datasets wouldn't pop a dialog. That also swallowed genuine service-launch failures.enable()now tags infrastructure failures withlaunchFailed, and the watcher always surfaces those in a dialog, while benign per-dataset failures (e.g. missing calibration) still degrade quietly.Notes
success: falsewith a clear message rather than an empty polygon) are handled in the correspondingviame.corePython service and are not part of this client diff.client/.electron/are gitignored and not included.