Open
Conversation
BryonLewis
force-pushed
the
ninja-uploadfile-fix
branch
from
4adf588 to
209ec18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploading WAV files to the interface failed.
This was caused by the Django ninja accessing the type of the parameter, which was
import UploadedFile from ninja.files.Django-Ninja seems to access the type definition during runtime when used as a parameter for an endpoint:
https://github.com/vitalik/django-ninja/blob/56e868754e4ede8a47beb1833c8f67d4134339ea/ninja/signature/details.py#L221
https://github.com/vitalik/django-ninja/blob/56e868754e4ede8a47beb1833c8f67d4134339ea/ninja/signature/details.py#L57-L86
Here you can see that if you don't include the type annotation for HTTPRequest and your first parameter isn't named 'request', you can run into the same error.