chore: enforce Conventional Commits via commitlint hook and CI#873
Merged
PaulHax merged 3 commits intoKitware:mainfrom May 8, 2026
Merged
chore: enforce Conventional Commits via commitlint hook and CI#873PaulHax merged 3 commits intoKitware:mainfrom
PaulHax merged 3 commits intoKitware:mainfrom
Conversation
Adds @commitlint/cli + @commitlint/config-conventional and wires a commit-msg hook through the existing yorkie setup so non-conforming messages are rejected locally. A new CI job runs commitlint against PR commits as a server-side safety net for --no-verify bypasses.
Project is "type": "module" so plain .js with `export default` is the modern shape; the .cjs extension was unnecessary friction.
Project is "type": "module" so plain prettier.config.js with
`export default` is the modern shape. Prettier auto-discovers
prettier.config.{js,cjs,mjs} in the cwd, so the explicit
--config ./prettier.config.cjs in lint-staged and the CI check
was redundant — removed both.
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@commitlint/cli+@commitlint/config-conventional; wire acommit-msghook through the existing yorkie setup so non-conforming messages are rejected locally.--no-verifybypasses)."type": "module":commitlint.config.jsandprettier.config.js(was.cjs); drop the redundant--config ./prettier.config.cjsflags now that prettier auto-discovers the config.Test plan
git commit -m "ultrasound: bad"is rejected locally by the commit-msg hookgit commit -m "fix(ultrasound): good"passescommitlintjob fails when a PR contains a non-conforming commitnpm run prettifyand the CI prettier check still format/check the same files