Don't check build count on every submission - #3922
Merged
williamjallen merged 1 commit intoAug 5, 2026
Merged
Conversation
CDash currently queries the exact number of builds in a project on every submission. While the query uses a reasonably efficient index scan, it still adds up to substantial database load during peak hours when many submissions are being received around the same time. This PR adds a caching mechanism to skip the check if it's been less than 10 minutes since the previous check. This approach means that the number of builds may briefly exceed the threshold, which seems like an acceptable tradeoff.
zackgalbreath
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDash currently queries the exact number of builds in a project on every submission. While the query uses a reasonably efficient index scan, it still adds up to substantial database load during peak hours when many submissions are being received around the same time. This PR adds a caching mechanism to skip the check if it's been less than 10 minutes since the previous check. This approach means that the number of builds may briefly exceed the threshold, which seems like an acceptable tradeoff.