Adjust XML schema for instrumentation changes - #3919
Merged
williamjallen merged 2 commits intoAug 4, 2026
Conversation
williamjallen
requested changes
Aug 4, 2026
Following the updates to CMake in https://gitlab.kitware.com/cmake/cmake/-/merge_requests/11251 and https://gitlab.kitware.com/cmake/cmake/-/merge_requests/12117 update the schema for the Build.xml files to allow the new `cmakeContent` attribute and remove the required flag for the `version` attribute
josephsnyder
force-pushed
the
update_instrumentation_schema
branch
from
August 4, 2026 17:07
a6b1cfc to
70b41a1
Compare
williamjallen
requested changes
Aug 4, 2026
williamjallen
left a comment
williamjallen
left a comment
Collaborator
There was a problem hiding this comment.
One stylistic comment to address and then I'll approve.
Co-authored-by: William Allen <16820599+williamjallen@users.noreply.github.com>
williamjallen
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the updates to CMake in
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/11251 and
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/12117
update the schema for the Build.xml files to allow the new
cmakeContentattribute and remove the required flag for theversionattribute