Skip to content

Fix flaky create project page test #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
williamjallen wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −22
Open

Fix flaky create project page test #3723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 32 additions & 22 deletions tests/Browser/Pages/CreateProjectPageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,13 @@ public function testShowsErrorWhenInvalidProjectNameProvided(): void
$this->browse(function (Browser $browser): void {
$browser->loginAs($this->users['admin'])
->visit('/projects/new')
->waitFor('@create-project-page')
->type('@project-name-input', 'invalid project name %')
->click('@create-project-button')
->waitFor('@project-name-validation-errors')
->assertSeeIn('@project-name-validation-errors', 'Project name may only contain letters, numbers, dashes, and underscores.')
->whenAvailable('@create-project-page', function (Browser $browser): void {
$browser->waitFor('@project-name-input')
->type('@project-name-input', 'invalid project name %')
->click('@create-project-button')
->waitFor('@project-name-validation-errors')
->assertSeeIn('@project-name-validation-errors', 'Project name may only contain letters, numbers, dashes, and underscores.');
})
;
});
}
Expand All @@ -93,11 +95,13 @@ public function testShowsErrorWhenProjectAlreadyExists(): void
$this->browse(function (Browser $browser) use ($project_name): void {
$browser->loginAs($this->users['admin'])
->visit('/projects/new')
->waitFor('@create-project-page')
->type('@project-name-input', $project_name)
->click('@create-project-button')
->waitFor('@project-name-validation-errors')
->assertSeeIn('@project-name-validation-errors', 'A project with this name already exists.')
->whenAvailable('@create-project-page', function (Browser $browser) use ($project_name): void {
$browser->waitFor('@project-name-input')
->type('@project-name-input', $project_name)
->click('@create-project-button')
->waitFor('@project-name-validation-errors')
->assertSeeIn('@project-name-validation-errors', 'A project with this name already exists.');
})
;
});
}
Expand All @@ -112,10 +116,12 @@ public function testCreateProjectSetDescription(): void
$this->browse(function (Browser $browser) use ($description, $name): void {
$browser->loginAs($this->users['admin'])
->visit('/projects/new')
->waitFor('@create-project-page')
->type('@project-name-input', $name)
->type('@project-description-input', $description)
->click('@create-project-button')
->whenAvailable('@create-project-page', function (Browser $browser) use ($description, $name): void {
$browser->waitFor('@project-name-input')
->type('@project-name-input', $name)
->type('@project-description-input', $description)
->click('@create-project-button');
})
->waitForReload()
;
});
Expand All @@ -135,10 +141,12 @@ public function testCreateProjectSetAuthenticatedSubmissions(): void
$this->browse(function (Browser $browser) use ($name): void {
$browser->loginAs($this->users['admin'])
->visit('/projects/new')
->waitFor('@create-project-page')
->type('@project-name-input', $name)
->click('@project-authenticated-submissions-input')
->click('@create-project-button')
->whenAvailable('@create-project-page', function (Browser $browser) use ($name): void {
$browser->waitFor('@project-name-input')
->type('@project-name-input', $name)
->click('@project-authenticated-submissions-input')
->click('@create-project-button');
})
->waitForReload()
;
});
Expand Down Expand Up @@ -171,10 +179,12 @@ public function testCreateProjectSetVisibility(string $fieldname, int $role): vo
$this->browse(function (Browser $browser) use ($fieldname, $name): void {
$browser->loginAs($this->users['admin'])
->visit('/projects/new')
->waitFor('@create-project-page')
->type('@project-name-input', $name)
->click('@project-visibility-' . $fieldname)
->click('@create-project-button')
->whenAvailable('@create-project-page', function (Browser $browser) use ($fieldname, $name): void {
$browser->waitFor('@project-name-input')
->type('@project-name-input', $name)
->click('@project-visibility-' . $fieldname)
->click('@create-project-button');
})
->waitForReload()
;
});
Expand Down