Skip to content

Comments

Revamp build error page#3470

Merged
josephsnyder merged 1 commit intoKitware:masterfrom
williamjallen:build-errors-page-refactor
Feb 24, 2026
Merged

Revamp build error page#3470
josephsnyder merged 1 commit intoKitware:masterfrom
williamjallen:build-errors-page-refactor

Conversation

@williamjallen
Copy link
Collaborator

This PR completely redesigns the build error page, using the GraphQL API to support a brand new UI. The route has been changed to /builds/<id>/errors with appropriate redirects, and the legacy /api/v1/viewBuildError.php API endpoint has been deprecated.

Before After
image image

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to the page looks good and is a great update.
I have one request that I'm definitely willing to make future work:

I think it would benefit us to collapse the "Standard Output" automatically if there were more than 50 lines of output. One of the Sacado subproject has 267 warnings each with long diffs and it takes over the whole page. I would also be fine if we had the equivalent of the original page which had a limited size box, each with its own scroll bar instead of adding to the length of the overall page

@williamjallen williamjallen force-pushed the build-errors-page-refactor branch from d6128a6 to 8acb211 Compare February 24, 2026 16:11
@williamjallen
Copy link
Collaborator Author

@josephsnyder Done. Stdout more than 20 lines long is now hidden by default. In the future, this could probably be improved by showing the first 20 lines and adding a "show more" widget instead.

@josephsnyder
Copy link
Member

@williamjallen, it seems like all stdout is hidden by default. There are several warnings of 2 or 3 lines that are closed automatically
20260224-1654-27 8452565

@williamjallen williamjallen force-pushed the build-errors-page-refactor branch from 8acb211 to 3c818cf Compare February 24, 2026 18:30
@williamjallen
Copy link
Collaborator Author

@josephsnyder Should be better now.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better. Thanks for the quick updates!

@josephsnyder josephsnyder added this pull request to the merge queue Feb 24, 2026
Merged via the queue into Kitware:master with commit 6ffba1b Feb 24, 2026
7 checks passed
@williamjallen williamjallen deleted the build-errors-page-refactor branch February 24, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants