Conversation
josephsnyder
left a comment
There was a problem hiding this comment.
The update to the page looks good and is a great update.
I have one request that I'm definitely willing to make future work:
I think it would benefit us to collapse the "Standard Output" automatically if there were more than 50 lines of output. One of the Sacado subproject has 267 warnings each with long diffs and it takes over the whole page. I would also be fine if we had the equivalent of the original page which had a limited size box, each with its own scroll bar instead of adding to the length of the overall page
d6128a6 to
8acb211
Compare
|
@josephsnyder Done. Stdout more than 20 lines long is now hidden by default. In the future, this could probably be improved by showing the first 20 lines and adding a "show more" widget instead. |
|
@williamjallen, it seems like all stdout is hidden by default. There are several warnings of 2 or 3 lines that are closed automatically |
8acb211 to
3c818cf
Compare
|
@josephsnyder Should be better now. |
josephsnyder
left a comment
There was a problem hiding this comment.
Definitely better. Thanks for the quick updates!

This PR completely redesigns the build error page, using the GraphQL API to support a brand new UI. The route has been changed to
/builds/<id>/errorswith appropriate redirects, and the legacy/api/v1/viewBuildError.phpAPI endpoint has been deprecated.