New command, 'ExecKclProject'#1236
Draft
adamchalmers wants to merge 2 commits into
Draft
Conversation
adamchalmers
commented
Jun 9, 2026
|
|
||
| /// Filepath which is guaranteed to be relative and not contain parent directory jumps like '..' | ||
| #[derive(Debug, Clone, PartialEq, Serialize, Deserialize, JsonSchema, Default)] | ||
| #[serde(transparent)] |
Collaborator
Author
There was a problem hiding this comment.
TODO: Make sure serde calls the validation path when deserializing from the network. Currently it bypasses the fn validate() when deserializing.
This command takes in a KCL project (which is a list of files, like a virtual filesystem directory) and returns the same Ok/Err result type that the frontend usually gets for KCL execution. Internally, it validates the filepaths (to make sure they're all relative to the KCL project root), and uses types from the frontend, which have been moved into a kcl-api crate.
adamchalmers
force-pushed
the
achalmers/kcl-in-engine
branch
from
0996da7 to
80874c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new command for executing KCL. Basically it:
We should also consider moving this project under the modeling-app monorepo, inside the
rust/dir as a workspace member.