fix: SBOM attestation and cosign identity matching#48
Merged
mikkeldamsgaard merged 1 commit intomainfrom Mar 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes release artifact verification for multi-arch images by correcting SBOM extraction in the release workflow and updates cosign verification instructions/targets to use regex-based certificate identity matching.
Changes:
- Fix SBOM attestation generation for multi-platform images by selecting the platform-keyed SBOM entry (
linux/amd64) in the Buildx inspect template. - Update cosign verification commands (docs + Makefile) to use
--certificate-identity-regexpinstead of--certificate-identity(glob patterns aren’t supported). - Document the above in the Unreleased changelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
docs/security.md |
Switches verification examples to --certificate-identity-regexp for tag-based identities. |
Makefile |
Updates verify-image target to use --certificate-identity-regexp and a new regexp variable. |
CHANGELOG.md |
Adds Unreleased notes describing the SBOM and cosign identity fixes. |
.github/workflows/release.yml |
Fixes SBOM predicate extraction for multi-arch image manifests by indexing the SBOM by platform. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…atching Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d00a4b6 to
b73b6d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullpredicate for multi-platform images by using(index .SBOM "linux/amd64").SPDXinstead of.SBOM.SPDX— the SBOM is keyed by platform in multi-arch manifests.--certificate-identitywith the exact tag ref (e.g.@refs/tags/v2.0.0) instead of a glob pattern (v*) which cosign does not support. The Makefile constructs the exact ref from theVERSIONparameter.How to verify
🤖 Generated with Claude Code