feat: add window function support#375
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 92.74% 92.84% +0.10%
==========================================
Files 243 249 +6
Lines 41025 41790 +765
==========================================
+ Hits 38049 38802 +753
- Misses 2976 2988 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
KiteSQL cannot currently bind or execute SQL window functions, so queries that need ranking or partition-level aggregate results are rejected.
Issue link: N/A
What is changed and how it works?
ROW_NUMBER,RANK,DENSE_RANK, andCOUNT/SUM/AVG/MIN/MAXwithOVER.QUALIFYas unsupported instead of silently accepting them.Code changes
Check List
Tests
The coverage includes ranking and aggregate functions, peer rows, null values, shared and different window specifications, duplicate calls, grouped aggregates feeding windows, View round trips, unsupported syntax, and Explain plans.
Side effects
Note for reviewer
Window functions with the same specification are evaluated together. A change in
PARTITION BYor windowORDER BYcreates another Sort and Window layer.