Skip to content

refactor: unify expression and operator traversal with visitors#372

Merged
KKould merged 3 commits into
mainfrom
refactor/operator-expression-visitors
Jul 11, 2026
Merged

refactor: unify expression and operator traversal with visitors#372
KKould merged 3 commits into
mainfrom
refactor/operator-expression-visitors

test: improve binder and operator coverage

498d051
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 11, 2026 in 0s

92.74% (+0.64%) compared to a28b4ab

View this Pull Request on Codecov

92.74% (+0.64%) compared to a28b4ab

Details

Codecov Report

❌ Patch coverage is 96.93815% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.74%. Comparing base (a28b4ab) to head (498d051).

Files with missing lines Patch % Lines
src/optimizer/rule/normalization/column_pruning.rs 84.54% 17 Missing ⚠️
src/binder/select.rs 84.31% 8 Missing ⚠️
src/planner/operator/visitor.rs 98.87% 5 Missing ⚠️
...mizer/rule/normalization/compilation_in_advance.rs 96.72% 4 Missing ⚠️
src/planner/operator/mod.rs 97.20% 4 Missing ⚠️
...ptimizer/rule/normalization/pushdown_predicates.rs 97.16% 3 Missing ⚠️
src/db.rs 75.00% 2 Missing ⚠️
src/optimizer/rule/normalization/elimination.rs 93.33% 2 Missing ⚠️
...ptimizer/rule/normalization/parameterized_index.rs 93.54% 2 Missing ⚠️
src/serdes/data_value.rs 96.66% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   92.09%   92.74%   +0.64%     
==========================================
  Files         241      243       +2     
  Lines       39870    41025    +1155     
==========================================
+ Hits        36720    38049    +1329     
+ Misses       3150     2976     -174     
Files with missing lines Coverage Δ
src/binder/aggregate.rs 97.59% <100.00%> (ø)
src/binder/distinct.rs 98.47% <ø> (ø)
src/binder/parser.rs 86.96% <100.00%> (ø)
src/catalog/column.rs 95.70% <100.00%> (ø)
src/catalog/view.rs 94.44% <100.00%> (+1.58%) ⬆️
src/expression/mod.rs 84.93% <100.00%> (ø)
src/expression/range_detacher.rs 93.64% <100.00%> (+0.29%) ⬆️
src/expression/simplify.rs 87.44% <ø> (ø)
src/expression/visitor.rs 92.65% <100.00%> (ø)
src/expression/visitor_mut.rs 93.64% <100.00%> (ø)
... and 18 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.