Skip to content

Add option to remove cache breakpoints to custom llm#3660

Merged
chrarnoldus merged 1 commit into
mainfrom
christiaan/cache-breakpoints
Jun 2, 2026
Merged

Add option to remove cache breakpoints to custom llm#3660
chrarnoldus merged 1 commit into
mainfrom
christiaan/cache-breakpoints

Conversation

@chrarnoldus
Copy link
Copy Markdown
Contributor

I'll use this to test the implicit caching of Qwen3.7

I'll use this to test the implicit caching of Qwen3.7
@chrarnoldus chrarnoldus self-assigned this Jun 2, 2026
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Jun 2, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The PR correctly implements removeCacheBreakpoints with recursive cache_control deletion, proper ordering (remove before add in buildDirectProvider), Zod v4-compatible schema updates, and solid test coverage across all three request kinds.

Files Reviewed (6 files)
  • apps/web/src/lib/ai-gateway/providers/openrouter/request-helpers.ts
  • apps/web/src/lib/ai-gateway/experiments/build-direct-provider.ts
  • apps/web/src/lib/ai-gateway/experiments/upstream-schema.ts
  • apps/web/src/lib/ai-gateway/providers/get-provider.ts
  • apps/web/src/lib/ai-gateway/providers/types.ts
  • apps/web/src/tests/openrouter-request-helpers.test.ts
  • packages/db/src/schema-types.ts

Reviewed by claude-sonnet-4.6 · 600,265 tokens

Review guidance: REVIEW.md from base branch main

export const ExperimentUpstreamSchema = z
.object({
internal_id: z.string().min(1),
base_url: z.string().url(),
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is deprecated

@chrarnoldus chrarnoldus merged commit cac6a06 into main Jun 2, 2026
49 checks passed
@chrarnoldus chrarnoldus deleted the christiaan/cache-breakpoints branch June 2, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants