Skip to content

Disclose free model data collection#3606

Merged
iscekic merged 7 commits into
mainfrom
feat/free-model-data-indicators
Jun 2, 2026
Merged

Disclose free model data collection#3606
iscekic merged 7 commits into
mainfrom
feat/free-model-data-indicators

Conversation

@iscekic
Copy link
Copy Markdown
Contributor

@iscekic iscekic commented May 30, 2026

Show a clear data-collection indicator anywhere users choose or view free Kilo models.

image

@iscekic iscekic self-assigned this May 30, 2026
Comment thread apps/web/src/components/shared/free-model-data-disclosure.ts Outdated
Comment thread apps/mobile/src/lib/free-model-data-disclosure.ts Outdated
Comment thread apps/web/src/components/shared/free-model-data-disclosure.ts Outdated
Comment thread apps/mobile/src/lib/free-model-data-disclosure.ts Outdated
Comment thread apps/web/src/components/shared/ModelCombobox.tsx Outdated
Comment thread apps/web/src/components/shared/ModelCombobox.tsx Outdated
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 30, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The latest commit (cf47151a3) removes the now-redundant collectsData prop from FreeModelDataBadge (always true inside the isFreeModelOption guard) and tightens the warning icon layout in trigger buttons by moving FreeModelDataIcon into a flex container alongside the truncated model name. Both changes are clean and correct — the cosmetic dead-code issue from the previous review is now resolved.

Files Reviewed (7 files, incremental)
  • apps/web/src/components/shared/ModelCombobox.tsxcollectsData prop removed, icon spacing fixed; clean
  • apps/web/src/components/shared/free-model-data-disclosure.ts — unchanged, carried forward
  • apps/web/src/components/shared/free-model-data-disclosure.test.ts — unchanged, carried forward
  • apps/mobile/src/lib/free-model-data-disclosure.ts — unchanged, carried forward
  • apps/mobile/src/lib/free-model-data-disclosure.test.ts — unchanged, carried forward
  • apps/mobile/src/app/(app)/agent-chat/model-picker.tsx — unchanged, carried forward
  • apps/mobile/src/components/agents/model-selector.tsx — unchanged, carried forward

Reviewed by claude-4.6-sonnet-20260217 · 389,688 tokens

Review guidance: REVIEW.md from base branch main

@iscekic iscekic requested a review from lambertjosh June 2, 2026 13:22
@iscekic iscekic enabled auto-merge (squash) June 2, 2026 13:23
@iscekic iscekic requested a review from pandemicsyn June 2, 2026 13:52
@lambertjosh
Copy link
Copy Markdown
Contributor

reviewing now, running locally

@lambertjosh
Copy link
Copy Markdown
Contributor

LGTM

@iscekic iscekic merged commit aca1e0f into main Jun 2, 2026
17 checks passed
@iscekic iscekic deleted the feat/free-model-data-indicators branch June 2, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants